Opened 12 years ago

Closed 8 years ago

Last modified 8 years ago

#3919 closed task (fixed)

ColorPalette: consider removing png files from non a11y mode

Reported by: Adam Peller Owned by: bill
Priority: low Milestone: 1.6.1
Component: Dijit Version: 1.0
Keywords: 1.7-mobile Cc: dfahey, liucougar
Blocked By: Blocking:

Description

If not in high contrast mode, perhaps we can do without the large png files and instead create the content programatically with a table or something. Also, perhaps it's possible to set title in a different way and avoid all those blank.gifs?

Change History (9)

comment:1 Changed 12 years ago by Adam Peller

Cc: dfahey added

comment:2 Changed 12 years ago by bill

Cc: liucougar added

We don't have or want separate codepaths for high contrast vs. normal (this is one of the axioms of dijit), so I don't see how this is possible, except by not having an image at all, and just displaying words in the table (for high contrast mode).

comment:3 Changed 11 years ago by Becky Gibson

Milestone: 1.11.2
Version: 0.91.0

comment:4 Changed 11 years ago by Becky Gibson

Milestone: 1.2future

comment:5 Changed 11 years ago by bill

Summary: consider removing png files from ColorPalette, non a11y modeColorPalette: consider removing png files from non a11y mode
Type: defecttask

comment:6 Changed 8 years ago by bill

Milestone: future1.6.1
Owner: changed from Becky Gibson to bill
Status: newassigned

comment:7 Changed 8 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [23979]) In non-high-contrast mode, use background-color CSS for color swatches, rather than an image. In high-contrast mode, make each color swatch contain an <img> node that loads the entire palette image, but scrolls/clips it to only show the color for that swatch.

This change avoids swatch/border alignment issues on webkit with a zoom setting, and alignment issues in other browsers, even when not zoomed, that started in 1.6, as seen in #12386.

Note that webkit never enters high contrast mode; even when the machine is set to high-contrast mode, the browser still displays background images. So webkit will always using background-color CSS.

Fixes #3919, #10959, #12386 in trunk/ and 1.6/ branch, !strict.

comment:8 Changed 8 years ago by bill

Keywords: 1.7-mobile added

comment:9 Changed 8 years ago by bill

(In [23990]) Remove unused files, the LTR files are now used even for RTL mode. Refs #3919.

Note: See TracTickets for help on using tickets.