Opened 15 years ago

Last modified 7 years ago

#3905 closed defect

Patch dojo.parser, OR stop putting widget code in event callbacks such as onShow, onRezised etc — at Initial Version

Reported by: mumme Owned by: bill
Priority: low Milestone: 2.0
Component: Dijit Version: 0.9
Keywords: parser, markup, dijit events Cc:
Blocked By: Blocking:

Description

Connecting to onShow in markup using TitlePane?, StackContainer? TabContainer? etc breaks href load.

This is just a symptom of a bigger problem. Say a designer wants to know when a TitlePane? shows

<div dojoType='dijit.TitlePane'  
    href='somepage'
    open='false'
    title='Foo'
    onShow='console.debug("opened")'
></div>

When dojo.parser parses this markup it replaces TitlePane?'s onShow function, which currently triggers the href download, with:

function(){console.debug("opened")}

So we either patch the parser to connect instead of replace OR stop using public functions in widget to widget calls (not sure that is possible in all cases).

I suspect it has been discussed extensively already, still code like this is still being added to dijit trunk. I searched trac but couldn't find any tickets filed about this yet. So I figured I open a ticket to make people aware of this.

/ Fredrik

Change History (0)

Note: See TracTickets for help on using tickets.