Opened 12 years ago

Closed 12 years ago

#3901 closed defect (fixed)

Progressbar breaks in IE

Reported by: Sam Foster Owned by: Adam Peller
Priority: high Milestone: 0.9
Component: Dijit Version: 0.9
Keywords: Cc: Adam Peller, wildbill, dante
Blocked By: Blocking:

Description

In theme tester (./dijit/themes/themeTester.html) IE gives an error, that when you debug fingers line 96. Perhaps it doesnt like assignment of 0%?

The error breaks the theme tester though...

Change History (3)

comment:1 Changed 12 years ago by Sam Foster

Cc: wildbill dante added

The issue does seem to be in or around the "divide by zero" fix, line 96: this.fullLabel.style.width = (this.progress ? (this.maximum / this.progress) * 100 : 0) + "%";

..which in the theme tester ends up assigning "NaN%" to the element width (making IE unhappy). If someone needs this fixed faster than me (getting swamped with work here) that's where to start looking.

comment:2 Changed 12 years ago by Adam Peller

Owner: changed from Sam Foster to Adam Peller

comment:3 Changed 12 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [9895]) Convert this.progress expression to a number in ternary expression so we don't do a div by zero. Seems like it should be a number already, but for some reason this is necessary on IE. Thanks, sfoster. Fixes #3901

Note: See TracTickets for help on using tickets.