TitlePane/fx.wipeOut() fail because dojo.style(node, "height") returns 0 (IE)

[bill]

See test_TitlePane.html on IE; each pane closes instantly rather than wiping closed, because dojo/_base/fx.js calls

prop.start = dojo.style(this.node, p);

(where p=="height"), which returns 0, even though the node is visible. Node has style.cssText="height: auto".

So, something has to be updated, either html.js, _base/fx.js, dojo/fx.js, or TitlePane.js. Seems like the problem is in html.js but I guess it's debatable?

[sjmiles]

dojo.style uses getComputedStyle.

Querying computedStyle.height is not a good idea to get the actual node height. In particular, on IE the computedStyle is still just "auto"

You should use a box method or simply node.offsetHeight.

[bill]

We need to change some code before this ticket can be closed. If we don't change dojo.html, the alternative is to modify fx to special case height (and width, I guess) when getting a style.

[sjmiles]

I always consider the title of the ticket to state it's objective. As stated, this ticket is not a valid bug. I imagined you would open a new ticket for the fx problem.

[bill]

OK, I'm uneasy about dojo.html() have browser specific behavior but I'll add workaround code into fx for now.

[bill]

(In [9858]) dojo.style(node, "height") can return "auto" or "" on IE rather than a number, so use offsetHeight instead. Fixes #3891.

[sjmiles]

This change probably will cause additional problems because node.style.height and offsetHeight are not always symmetrical (depending on box-model, borders, and padding).

[bill]

That's true, but in general height/width related animation won't work on nodes that have border/padding/margin, because of those box-model differences. Maybe it should be browser specific code, only accessing offsetHeight for IE.