Opened 12 years ago

Closed 12 years ago

#3890 closed defect (fixed)

markup href not working for ContentPane

Reported by: guest Owned by: mumme
Priority: high Milestone: 0.9
Component: Dijit Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

This was working in the 0.9 Beta . Downloaded new src from SVN HEAD today , and had problems with it :

<div dojoType="dijit.layout.ContentPane" parseOnLoad="true" class="box" href="somepage.html" id="test"></div>

Would not show any content . I played arround and noticed that manually calling setHref makes it work . I also checked the tests and test_ContentPane seems to be broken for this , the first test that uses markup href doesn't work , but the second one , that uses .setHref works .

I was able to work arround it by this quick and dirty trick :

dojo.addOnLoad(function () { 
			dijit.byId('test').setHref('somepage.html');
		});

kosz

Change History (4)

comment:1 Changed 12 years ago by bill

Component: CoreDijit
Resolution: invalid
Status: newclosed

Right, for this uncommon case when you have a ContentPane? with an href that's *not* inside a TabContainer? etc. you need to set preload=true. I'll update the porting guide (it's already documented in the API doc, check the comments in the file).

comment:2 Changed 12 years ago by mumme

Resolution: invalid
Status: closedreopened

Actually, it should work and we have a test for it in test_ContentPane.html

The widget at page bottom is supposed to load an external page, agreed it is very easy to miss.

I'l checkin a updated testcase that shows if it isn't loading as it should

I discussed this with Bill earlier today on IRC, and he agreed.

comment:3 Changed 12 years ago by mumme

Owner: changed from anonymous to mumme
Status: reopenednew

comment:4 Changed 12 years ago by mumme

Resolution: fixed
Status: newclosed

(In [9853]) Re-add a startup() _loadCheck, makes loading from markup by href work again. Updated regressiontests to make this easier to spot

Fixes #3890 and Fixes #3892

Note: See TracTickets for help on using tickets.