Opened 12 years ago

Closed 12 years ago

Last modified 10 years ago

#3874 closed enhancement (fixed)

dojo.marginBox() doesn't work with default border width

Reported by: Jared Jurkiewicz Owned by: sjmiles
Priority: high Milestone: 1.1
Component: HTML Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

Original description:

Using 0.9 LayoutContainer? and ContentPanes?, it appears that in IE 6 the right edge of the stuff in the content panes are clipped off the view. In FireFox? and Safari it's fine.

I made a testcase that shows this. It's actually from some doc I've been working on and discovered the clipping issue.

Note from Bill: It's a problem with dojo.marginBox() when the border width isn't specified. The border width defaults to the string "medium", which is 4px, but dojo._toPixelValue(node, "medium") returns 0 (rather than 4).

Attachments (1)

multi_viewlayout.html (2.9 KB) - added by Jared Jurkiewicz 12 years ago.
Testcase that shows the clipping issue.

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by Jared Jurkiewicz

Attachment: multi_viewlayout.html added

Testcase that shows the clipping issue.

comment:1 Changed 12 years ago by Jared Jurkiewicz

Component: GeneralDijit
Owner: changed from anonymous to bill
Type: defecttask

comment:2 Changed 12 years ago by bill

Milestone: 0.9

comment:3 Changed 12 years ago by Jared Jurkiewicz

Clarification of what is clipping. The border on the contentpane/div. I have CSS styles set to mae a 3dlike border on them, and the right edge one gets clipped off in IE. It's visible in Firefox and Safari.

comment:4 Changed 12 years ago by bill

Component: DijitHTML
Description: modified (diff)
Owner: changed from bill to sjmiles
Summary: 0.9: ContentPanes in IE 6 appear to clip the right edge of the contents.dojo.marginBox() doesn't work with default border width

comment:5 Changed 12 years ago by sjmiles

Milestone: 0.91.0
Status: newassigned
Type: taskenhancement

This is a known issue (comments to that effect are in the code I believe).

The current system requires a border style to be given an explicit width.

It may be possible to reliably convert some of these textual values into pixel values, so I'm going to mark this ticket as an enhancement for 1.0.

comment:6 Changed 12 years ago by sjmiles

(In [10186]) Make toPixelValue translate 'medium' to 4, hack refs #3874.
Repair scrolling adjustment in _abs, fixes #3455.

comment:7 Changed 12 years ago by sjmiles

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.