Opened 13 years ago
Closed 13 years ago
#3841 closed enhancement (invalid)
[patch][cla]dojo _loader has redundant code
| Reported by: | dante | Owned by: | alex |
|---|---|---|---|
| Priority: | high | Milestone: | 0.9 |
| Component: | Core | Version: | 0.9 |
| Keywords: | code size | Cc: | |
| Blocked By: | Blocking: |
Description
unless I'm missing something huge, we're not using package.js anymore.
small cleanup attached. tested, but unsure/unaware it will mess with xd-loader, or if i am just 'missing something' ...
Attachments (1)
Change History (7)
Changed 13 years ago by
| Attachment: | loader.patch added |
|---|
comment:1 Changed 13 years ago by
comment:2 Changed 13 years ago by
| Owner: | changed from anonymous to James Burke |
|---|
comment:3 Changed 13 years ago by
| Summary: | dojo _loader has redundant code → [patch][cla]dojo _loader has redundant code |
|---|
comment:4 Changed 13 years ago by
| Owner: | changed from James Burke to alex |
|---|
Even though we are not using * to package.js mapping in the toolkit anymore, I thought we were still going to support it for folks that had code that they port to 0.9. Assigning to Alex to get confirmation.
comment:5 Changed 13 years ago by
track ticket #78 is a conflict in using _package_ and zope. if leaving it there, we should either provide a new base filename using that, or deprecate it and use profiles and provide porting notes on howto?
comment:6 Changed 13 years ago by
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
OK, #78 has been addressed and like jburke said, even though we are not using * to package.js mapping in the toolkit anymore, we are still going to support it for folks that had code that they port to 0.9.
seeing it in color, lines 291 and 294 can also be removed without affecting anything.