Opened 15 years ago
Closed 15 years ago
#3824 closed defect (fixed)
[dojo.data] missing "var" in ItemFileWriteStore on line 278
Reported by: | skinner | Owned by: | Jared Jurkiewicz |
---|---|---|---|
Priority: | lowest | Milestone: | |
Component: | Data | Version: | 0.9 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
on line 278, I think this
typeMap = this._datatypeMap[type];
should instead be this
var typeMap = this._datatypeMap[type];
(An aside: I wonder if it would be possible to write a simple unit test for this sort thing -- a unit test that pulls in *all* the dojo modules and then just checks to make sure that the only global variable that got added was "dojo"?)
Attachments (1)
Change History (5)
comment:1 Changed 15 years ago by
comment:2 Changed 15 years ago by
You need other global variables now and then. For example, the FlickrStore? requires a global function for handling the data returned. So a test requiring only dojo being defined isn't so good.
comment:3 Changed 15 years ago by
For examples, perhaps, but for the Dojo library, we're pretty strict about global variables. It's a worthwhile test to run. You can always be selective about the results, or perhaps if you think a DOH test needs to include a global variable, we could have an API to declare it so it doesn't get flagged as an error.
Changed 15 years ago by
Attachment: | data_ItemFileWriteStore_20070723.patch added |
---|
comment:4 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [9754]) Trivial fix in ItemFireWriteStore? fixes #3824
well, wouldn't you have to exercise most of the code, too? Perhapst his would be a good addition to DOH. I'd suggest a separate ticket.