Opened 14 years ago
Closed 13 years ago
#3816 closed defect (invalid)
xdomain loading: loader_xd.js sets dojo._isXDomain too much?
Reported by: | James Burke | Owned by: | James Burke |
---|---|---|---|
Priority: | high | Milestone: | 0.9 |
Component: | Loader | Version: | 0.9 |
Keywords: | Cc: | Robert Coup | |
Blocked By: | Blocking: |
Description
loader_xd.js sets dojo._isXDomain for each module call, but it seems like only the djConfig setting should be the indicator. Scrub down the dojo._isXDomain calls, maybe another place needs the value per-module but does not have access to the currentIsXDomain local variable.
It may be a non-issue, since in the local module case, it will be set to false, and things will load as desired synchronously, and for non-xd modules, after the module is attached as a script node, it looks like dojo._isXDomain may not be referenced to do anything. If that is the case, then maybe look at removing currentIsXDomain.
Change History (2)
comment:1 Changed 14 years ago by
comment:2 Changed 13 years ago by
Resolution: | → invalid |
---|---|
Status: | new → closed |
Yeah I think its ok, but the use case is pretty convoluted:
- Load dojo.xd.js
- Don't set
djConfig.useXDomain=true
- Load local modules via
dojo.require()
synchronously - Later start loading x-domain modules via
dojo.require()
and using onLoad callbacks...
I have forgotten code I wrote and how to read code. :) Thanks to rcoup for pointing out the explanation in dojo._xdReset (that I wrote!). I think the code is correct, but leaving this bug open for a little bit until rcoup has time to evaluate.