Opened 12 years ago

Closed 12 years ago

Last modified 8 years ago

#3789 closed defect (fixed)

Slider: control button look and feel via theme

Reported by: bill Owned by: dante
Priority: high Milestone: 0.9
Component: Dijit - Form Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

Buttons on the slider should be controlled via the theme, rather than having HTML specified in an attribute. The only attribute should be showButtons=true/false.

Attachments (1)

update.patch (8.8 KB) - added by dante 12 years ago.
progress check, is this the right direction?

Download all attachments as: .zip

Change History (7)

comment:1 Changed 12 years ago by bill

Description: modified (diff)
Status: newassigned
Summary: Slider: specify buttons as inlineHTML rather than as attributeSlider: don't specify buttons as HTML in an attribute

comment:2 Changed 12 years ago by bill

(In [9695]) Don't specify button HTML inside an attribute. Instead, should be controlled via the theme. This checkin gets us halfway there. Still need to make the theme override the default +/- text with icons. Refs #3789.

comment:3 Changed 12 years ago by bill

Owner: changed from bill to dante
Status: assignednew
Summary: Slider: don't specify buttons as HTML in an attributeSlider: control button look and feel via theme

Peter, can you do the rest when you fix all the other arrows? I think the buttons in the template should specify iconClass, and then the theme can hide the text and display the icon instead. Similar to Toolbar buttons.

comment:4 Changed 12 years ago by dante

Status: newassigned

Changed 12 years ago by dante

Attachment: update.patch added

progress check, is this the right direction?

comment:5 Changed 12 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [9703]) incremental checkin refs #3661 (unify icons)

and fixes #3796, #3790, #3656, #3626, #3512, #3789, #3668 via various Input elemet styles, tundra cleanups, tabContainer changes, and more ...

comment:6 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.