Opened 14 years ago
Closed 14 years ago
#3754 closed defect (fixed)
Inconsistent Esc key handling across form widgets
Reported by: | ptbrunet | Owned by: | ptbrunet |
---|---|---|---|
Priority: | high | Milestone: | 0.9 |
Component: | Dijit | Version: | 0.9 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description (last modified by )
[edited to be more consistent with followup comments by reporter by Karl (tk)]
Esc key handling is inconsistent across the following widgets: This is the current behavior for the Esc key on all the widgets in .../dijit/tests/form/test_InlineEditBox.html
text box textarea date text box filtering select programmed text box spinner
More details can be found in the follow up comments by the reporter.
Change History (10)
comment:1 Changed 14 years ago by
Owner: | changed from bill to Douglas Hays |
---|
comment:2 Changed 14 years ago by
Owner: | changed from Douglas Hays to haysmark |
---|
comment:3 Changed 14 years ago by
Owner: | changed from haysmark to ptbrunet |
---|
comment:4 Changed 14 years ago by
comment:5 Changed 14 years ago by
A second autoSave version of the text area was recently added to the test case so the third widget mentioned above in comment 4 is really the fourth - and so on.
comment:6 Changed 14 years ago by
Description: | modified (diff) |
---|---|
Summary: | DatePicker: When it's open, Esc doesn't close the edit box or the popup → Inconsistent Esc key handling across form widgets |
comment:7 Changed 14 years ago by
comment:8 Changed 14 years ago by
comment:9 Changed 14 years ago by
I think this can be closed. I opened #4050 for an additional bug that's not already fixed related to this.
4050 Inline autoSave filtering select - pressing Esc immediately closes box, should just revert
comment:10 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
This is the current behavior for the Esc key on all the widgets in .../dijit/tests/form/test_InlineEditBox.html
First widget, text box:
Second widget, textarea
Third widget, date text box: like the second widget (bug).
Fourth widget, filtering select
Fifth widget, programmed text box: like the first widget (bug).
Sixth widget, spinner: (no bugs)
The correct behavior is:
Note: It could be argued that for consistency Esc should have to be pressed twice even when there are no prior edits.
The date hierarchy look like this: DateTextBox, RangeBoundTextbox, MappedTextbox, ValidationTextbox, Textbox, _FormWidget, etc.
The fix Doug did to implement the revert feature is in change set 9627, bundled in with the fix for 3610, in _onKeyPress handler in _FormWidget.