Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#374 closed enhancement (fixed)

Dialog - correct background sizing for short pages.

Reported by: tonyissakov@… Owned by: bill
Priority: low Milestone:
Component: Widgets Version: 0.2
Keywords: Cc:
Blocked By: Blocking:

Description

currently the background in dialog is sized by:

var h = document.documentElement.scrollHeight
dojo.html.body().scrollHeight;

in the method "dojo.widget.HtmlDialog?.sizeBackground". If the page is short the background will not consume the whole of the visible space. This doesn't seem quite right.

Better to do something like get the window visible area (dojo.html.getViewportHeight()) and compare it to the above scroll height. if the scroll height is less than window viewport height then use the viewport one. This makes sure the window is always covered up.

Change History (3)

comment:1 Changed 13 years ago by bill

Milestone: 0.3release
Owner: changed from anonymous to bill

See also #457 (but it's basically just a duplicate)

comment:2 Changed 13 years ago by bill

Resolution: fixed
Status: newclosed

Fixed in rev 3555.

comment:3 Changed 12 years ago by (none)

Milestone: 0.3release

Milestone 0.3release deleted

Note: See TracTickets for help on using tickets.