Opened 12 years ago

Closed 12 years ago

#3716 closed defect (fixed)

AccordionPane broken for contained widgets

Reported by: bill Owned by: Adam Peller
Priority: high Milestone: 1.0
Component: Dijit Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

When AccordionPane? contains a SplitContainer? etc, it needs to call SplitContainer?.resize() to set the SplitContainer?'s size to match the AccordionPane?'s content area size. Not working correctly:

  • AccordionContainer::layout() calls AccordionPane?.resize() by mistake
  • AccordionContainer::transition() calls code below which will fire too often,

for example, when the container has a bunch of text followed by multiple dijit.form.Button widgets (it will try to expand each button to the full size of the AccordionPane?).

dojo.forEach(newWidget.getChildren(), function(widget){
	if(widget.resize){
		widget.resize({h: paneHeight});
	}
});

Probably should have a new widget type like LayoutAccordionPane?, that expects a single child widget to be expanded to the correct space?

Change History (6)

comment:1 Changed 12 years ago by Adam Peller

contained complex widgets was de-supported for 0.9. Pushing back to 1.0

comment:2 Changed 12 years ago by Adam Peller

Milestone: 0.91.0

comment:3 Changed 12 years ago by Adam Peller

(In [10716]) Update comments for AccordionPane?. Refs #3716

comment:4 Changed 12 years ago by Adam Peller

Milestone: 1.01.1

comment:5 Changed 12 years ago by Adam Peller

(In [10719]) Update comments for AccordionPane?. Refs #3716

comment:6 Changed 12 years ago by bill

Milestone: 1.11.0
Resolution: fixed
Status: newclosed

I assume this is fixed along with #4826 (except for the outstanding issue in #5169).

Note: See TracTickets for help on using tickets.