Opened 12 years ago

Closed 12 years ago

Last modified 9 years ago

#3686 closed defect (fixed)

Slider: use standard attribute for specifying position of children

Reported by: bill Owned by: Douglas Hays
Priority: high Milestone: 0.9
Component: Dijit - Form Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

Current API for specifying layout position is OK:

<div dojoType="dijit.form.HorizontalRule" container="topDecoration" ...></div>

But the problem is implementation. Can't create slider programatically:

new dijit.form.HorizontalRule({container: "topDecoration", ...});

Probably can be solved by removing custom code from _Templated to handle container flag and instead just do something like this in postCreate():

dojo.forEach(this.getChildren(), function(child){
 this[child.container].appendChild(child.domNode);
});

Change History (6)

comment:1 Changed 12 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [9574]) Fixes #3686. Removed child.container processing from _Templated.js and added startup() to Slider.js to handle children placed within the wrong decoration container.

comment:2 Changed 12 years ago by bill

(In [9632]) Revert [9629]. It broke many of the widget tests including test_Button.html. "" is not an invalid value. Also need to print the widget's id or at least declaredClass. Reopens and refs #3686.

comment:3 Changed 12 years ago by bill

Resolution: fixed
Status: closedreopened

Ignore the above two comments, which obviously refer to a different bug (but I don't know what #)

comment:4 Changed 12 years ago by Douglas Hays

Resolution: fixed
Status: reopenedclosed

I thought this was fixed in [9574].

comment:5 Changed 12 years ago by bill

Note to self: I confused this bug with #3700. This bug is indeed fixed.

comment:6 Changed 9 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.