Opened 13 years ago

Closed 13 years ago

#3682 closed defect (fixed)

parser unit tests are failing

Reported by: alex Owned by: bill
Priority: high Milestone: 0.9
Component: Parser Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description


Change History (6)

comment:1 Changed 13 years ago by alex

(In [9552]) turn parsing on in the parser tests ;-). Refs #3682

comment:2 Changed 13 years ago by alex

Resolution: → fixed
Status: new → closed

(In [9557]) ensuring the that parser tests pass and that the parser is working for some builtins attrs where it previously failed. Fixes #3682

comment:3 Changed 13 years ago by bill

Priority: normal → high
Resolution: fixed
Status: closed → reopened

Above change broke various things (like the tab label not matching the displayed contents) because it's now mixing in things as attribute values like the toString function (IE, native values). Offending line is apparently: 

				var attrValue = node.getAttribute(attrName)||node[attrName];

comment:4 Changed 13 years ago by dante

(In [9558]) reverting parser.js changes from chengeset 9557. broke: TabContainer?, Editor, and more. refs #3682 ... "bill made me doit."

comment:5 Changed 13 years ago by bill

Owner: changed from alex to bill
Status: reopened → new

comment:6 Changed 13 years ago by bill

Resolution: → fixed
Status: new → closed

(In [9951]) Fix parser bugs reading disabled/checked, and also b="false" and foo="" type attributes (which should be obeyed not ignored).

Make date="" convert to an invalid date (the NaN of dates), and date="now" convert to the current date.

Fixes #3682, #3968.

Note: See TracTickets for help on using tickets.