Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#3669 closed defect (fixed)

[dojo.data] make shared tests for ItemFileReadStore and ItemFileWriteStore

Reported by: skinner Owned by: skinner
Priority: low Milestone:
Component: Data Version: 0.9
Keywords: Cc: jared.jurkiewicz@…
Blocked By: Blocking:

Description

The unit tests for ItemFileWriteStore are a super-set of the read-only unit tests for ItemFileReadStore. ItemFileWriteStore must pass all the same read-only tests that ItemFileReadStore passes, plus additional tests that check the write-access methods.

Currently, the ItemFileWriteStore unit test file simply has a copy of all the read-only tests in the ItemFileReadStore unit test file, which is a bad arrangement because the two sets of read-only tests can get out of sync.

It should be easy to come up with a better solution, where we define a single test set for the read-only tests, and then run that test set against both ItemFileReadStore and ItemFileWriteStore.

Change History (3)

comment:1 Changed 12 years ago by skinner

Resolution: fixed
Status: newclosed

(In [9547]) fixes #3669 Re-factored the unit tests for ItemFileReadStore? and ItemFileWriteStore?, so that the common tests are shared in a common file. Deleted 1,500 of duplicate code.

comment:2 Changed 12 years ago by skinner

Resolution: fixed

(In [9548]) fixes #3669 Re-factored the unit tests for ItemFileReadStore? and ItemFileWriteStore?, so that the common tests are shared in a common file. Deleted 1,500 of duplicate code.

comment:3 Changed 12 years ago by skinner

Resolution: fixed

(In [9560]) this time for sure... fixes #3669 Re-factored the unit tests for ItemFileReadStore? and ItemFileWriteStore?, so that the common tests are shared in a common file.

Note: See TracTickets for help on using tickets.