#3666 closed defect (fixed)
dijit.form.Checkbox style issues
Reported by: | dante | Owned by: | dante |
---|---|---|---|
Priority: | high | Milestone: | 1.0 |
Component: | Dijit - Form | Version: | 0.9 |
Keywords: | 4dijit style | Cc: | |
Blocked By: | Blocking: |
Description
on the first part of the new dojo book, there were many many questions about why styling was not present after copy/pasting tutorial.
turns out, in order for checkbox to style properly, it _requires_ the inclusion of the dojo.css file in /dojo/resources/
(dojo.css claims it is not 'required' for dijit to work) should Checkbox have more specific settings in dijit.css? or should dojo.css be included in dijit.css as a basic style mechanism. (why is dojo styling anything?) fixed the book page with everything required, but it caused a lot of confused users with comments [me included].
it also points out we need to work on the book as well as the porting guide in this time of alerting users to our new 0.9beta release.
Attachments (1)
Change History (7)
comment:1 Changed 14 years ago by
Keywords: | 4dijit style added |
---|
comment:2 Changed 14 years ago by
Component: | book → Dijit |
---|---|
Milestone: | 0.9 → 1.0 |
Owner: | changed from carlavmott to bill |
severity: | major → minor |
comment:3 Changed 14 years ago by
I ran into a styling issue with the radio button and checkbox when the following CSS was present:
input { margin:4px; }
The attached patch fixes the problem for the checkbox and radio button.. i agree that dojo.css should not be required.
CLA on file - Jonathan Bond-Caron
comment:4 Changed 14 years ago by
Owner: | changed from bill to dante |
---|
comment:5 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [9844]) incremental patch refs #3661 and fixes #3666 (checkbox dep on dojo.css) ... in this: Accordion Arrow change, Calendar Increment/Decrement? icon change, and cleanup.
comment:6 Changed 10 years ago by
Component: | Dijit → Dijit - Form |
---|
This is fixed in the book (the example now includes dojo.css; not sure if it did before or not). Should fix things though to checkboxes work without including dojo.css. Assigning to dijit.