Opened 12 years ago

Closed 12 years ago

Last modified 8 years ago

#3666 closed defect (fixed)

dijit.form.Checkbox style issues

Reported by: dante Owned by: dante
Priority: high Milestone: 1.0
Component: Dijit - Form Version: 0.9
Keywords: 4dijit style Cc:
Blocked By: Blocking:

Description

on the first part of the new dojo book, there were many many questions about why styling was not present after copy/pasting tutorial.

http://dojotoolkit.org/book/dojo-book-0-9/part-1-life-dojo/example-1-why-doesnt-anyone-fill-out-their-tax-forms/adding-some

turns out, in order for checkbox to style properly, it _requires_ the inclusion of the dojo.css file in /dojo/resources/

(dojo.css claims it is not 'required' for dijit to work) should Checkbox have more specific settings in dijit.css? or should dojo.css be included in dijit.css as a basic style mechanism. (why is dojo styling anything?) fixed the book page with everything required, but it caused a lot of confused users with comments [me included].

it also points out we need to work on the book as well as the porting guide in this time of alerting users to our new 0.9beta release.

Attachments (1)

margin-checkbox.patch (2.0 KB) - added by guest 12 years ago.
Fixes requirement on dojo.css ?

Download all attachments as: .zip

Change History (7)

comment:1 Changed 12 years ago by dante

Keywords: 4dijit style added

comment:2 Changed 12 years ago by bill

Component: bookDijit
Milestone: 0.91.0
Owner: changed from carlavmott to bill
severity: majorminor

This is fixed in the book (the example now includes dojo.css; not sure if it did before or not). Should fix things though to checkboxes work without including dojo.css. Assigning to dijit.

Changed 12 years ago by guest

Attachment: margin-checkbox.patch added

Fixes requirement on dojo.css ?

comment:3 Changed 12 years ago by guest

I ran into a styling issue with the radio button and checkbox when the following CSS was present:

input { margin:4px; }

The attached patch fixes the problem for the checkbox and radio button.. i agree that dojo.css should not be required.

CLA on file - Jonathan Bond-Caron

comment:4 Changed 12 years ago by bill

Owner: changed from bill to dante

comment:5 Changed 12 years ago by dante

Resolution: fixed
Status: newclosed

(In [9844]) incremental patch refs #3661 and fixes #3666 (checkbox dep on dojo.css) ... in this: Accordion Arrow change, Calendar Increment/Decrement? icon change, and cleanup.

comment:6 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.