Opened 12 years ago

Closed 12 years ago

#3661 closed enhancement (fixed)

unify icons in tundra.css (?)

Reported by: dante Owned by: dante
Priority: high Milestone: 1.0
Component: Dijit - LnF Version: 0.9
Keywords: Cc: ptbrunet
Blocked By: Blocking:

Description

the attached patch adds an extra node to calendar template to allow custom styling of next / prev buttons, while still keeping the a11y class and text-arrows ... not sure if this is _correct_ method, but it works, and improves visual aspect [imho] of the widget.

my thinking was that all the dijit's should have a unified icon set to use in tundra, and re-use them where possible for aesthetics. I just personally happen to like tabcontainers simple "circle-x" close icon, and made single-arrow directional icons to use in dojox.presentation ...

filing this ticket to hold patch and screenshot. css changes tested in ie6/safari-win/ff2 ... not sure if Calendar template modifications are 'ok' [regarding a11y and images off].

Attachments (2)

calendar.png (11.2 KB) - added by dante 12 years ago.
screenshot of changes
calendarTundra.patch (2.2 KB) - added by dante 12 years ago.
the patch to make the changes

Download all attachments as: .zip

Change History (22)

Changed 12 years ago by dante

Attachment: calendar.png added

screenshot of changes

Changed 12 years ago by dante

Attachment: calendarTundra.patch added

the patch to make the changes

comment:1 Changed 12 years ago by bill

Milestone: 1.00.9
Owner: changed from dylan to dante

OK Peter, can you make the changes so all the widgets support icons properly (but revert to the characters when <body class="dijit_a11y">), and then check in some icons? If Torrey doesn't like them we can let him redesign them. I'm sure there's more than just Calendar but I don't know exactly what.

comment:2 Changed 12 years ago by dante

Status: newassigned

comment:3 Changed 12 years ago by bill

Oh here's Torrey's email (saving it in the bug for posterity):

I don't have a strong preference either way but I tend to agree with the creator of the ticket. Close and the arrows have potentially the same action. They hide (or show) content. So they should probably look the same.

The spinner arrows look different because they are like a submit button in that they do something with the data. The spinner button when clicked changes the data up or down.

Titlepane arrows are the same as the arrows on the calendar, they show show and hide data. I think this distinction should be that buttons that perform an action on the data look one way and ones that show/hide data look another.

But I'm definitely open to discussion on that.

comment:4 Changed 12 years ago by dante

(In [9703]) incremental checkin refs #3661 (unify icons)

and fixes #3796, #3790, #3656, #3626, #3512, #3789, #3668 via various Input elemet styles, tundra cleanups, tabContainer changes, and more ...

comment:5 Changed 12 years ago by bill

(In [9710]) remove unused parameter. refs #3661.

comment:6 Changed 12 years ago by dante

(In [9733]) refs #3661 (icon tundra unity) and fixes #3820 #3822 and #1891

comment:7 Changed 12 years ago by dante

(In [9844]) incremental patch refs #3661 and fixes #3666 (checkbox dep on dojo.css) ... in this: Accordion Arrow change, Calendar Increment/Decrement? icon change, and cleanup.

comment:8 Changed 12 years ago by Adam Peller

(In [9861]) bidi: fix rtl arrows on calendar. Refs #3661

comment:9 Changed 12 years ago by dante

(In [9998]) tundra cleanup/change refs #3661 - and fixed #3991, #3992, and #3993

comment:10 Changed 12 years ago by dante

(In [10016]) refs #3661 (almost closed?)

fixes #3991 (forgot menu icons), and updates themeTester to use a form.button for closing. Also fixes #3930 (had to move dijitOpen/Closed class to focusNode inside of dijitTitlePane, revert if this is horribly wrong)

comment:11 Changed 12 years ago by dante

(In [10017]) refs #3661 - fixes #4022 - any css experts with an opinion?

comment:12 Changed 12 years ago by dante

Milestone: 0.91.0

moving this to 1.0 - all leg-work is done, may need some polish - and i agree w/ bill in the regard that (for instance) the arrow*.png/gif files should be one image with background-position coordinates to limit the number of files that get pulled w/ each page. should open new ticket for that and close this? perhaps spinner needs some styling love, but i personally like the small black arrow in some places. again: marking as "polish" for 1.0

comment:13 Changed 12 years ago by dante

(In [10044]) refs #3661 - add icon node to ComboBox? for easier custom modification. and adds missing combobox example to themeTester.

comment:14 Changed 12 years ago by ptbrunet

Cc: ptbrunet added

comment:15 Changed 12 years ago by dante

(In [10050]) refs #3661 - fixes overflow/cutoff on arrownodes in ie6/7 and bleedthrough of left-hand icons in all browsers.

comment:16 Changed 12 years ago by dante

(In [10056]) refs #3661 - picky IE6 - forces hide of close node on popup menu expand icon. only affected Menu/ie6/themeTester combo ...

comment:17 Changed 12 years ago by dante

(In [10061]) refs #3661 - "oops", input looked better when they weren't defaulting to the .png in ie6 ... attempts to make a gradient .gif to match have failed. punting this task for now, and reverting. (if anyone can make a duplicate .gif from dojoTundraGradientBg.png that would be neat, thanks)

comment:18 Changed 12 years ago by bill

By the way don't forget slider, which should be using the up/down arrow icons for vertical slider, and then left/right for horizontal, except in high-contrast mode where it should be using +/- characters w/out any styling. See #4182.

comment:19 Changed 12 years ago by dante

(In [10445]) checkin refs #3661 - adding unified icon nodes to Sliders, touches tundra.css and soria.css - adding in RTL styles too (though Slider is still broken functionally in RTL). fixes #4387 by adding disabled state styling to slider, and fixes #4379 by applying small patch wrt to Buttons courtesy Bryan Forbes.

comment:20 Changed 12 years ago by dante

Resolution: fixed
Status: assignedclosed

seems this is done in tundra. reopen if something is horribly missing, with the exception of new widgets. file a new ticket for new tundra or soria bugs, and remember you can press ctrl-f9 in dijit test pages to skip between themes. soria still needs a little love, and some serious ie6 wizardry, but tundra is down to polish and oversights.

Note: See TracTickets for help on using tickets.