Opened 12 years ago

Closed 12 years ago

#3656 closed defect (fixed)

Wrong class specified for dijitDialogContent

Reported by: guest Owned by: dante
Priority: high Milestone: 1.0
Component: Dijit Version: 0.9
Keywords: Cc: charlie-dojo@…
Blocked By: Blocking:

Description

The Dialog dijit has the content div set to dijitTitlePaneContent when it should be set to dijitDialogContent. Patch for dijit/Dialog.js follows:

--- /Library/WebServer/Documents/javascript/dojo-0.9.0beta/dijit/Dialog-orig.js 2007-07-03 13:13:48.000000000 +1000
+++ /Library/WebServer/Documents/javascript/dojo-0.9.0beta/dijit/Dialog.js      2007-07-07 16:39:03.000000000 +1000
@@ -82,7 +82,7 @@
                //              and also graying out the screen Dialog is extended from
                //              ContentPane so it supports all the same parameters (href, etc.)
 
-               templateString:"<div class="dijitDialog">
		<div dojoAttachPoint="titleBar" class="dijitDialogTitleBar" tabindex="0" waiRole="dialog" title="${title}">
		<span dojoAttachPoint="titleNode" class="dijitDialogTitle">${title}</span>
		<span dojoAttachPoint="closeButtonNode" class="dijitDialogCloseIcon" dojoAttachEvent="onclick: hide">
			<span dojoAttachPoint="closeText" class="closeText">x</span>
		</span>
	</div>
		<div dojoAttachPoint="containerNode" class="dijitTitlePaneContent"></div>
	<span dojoAttachPoint="tabEnd" dojoAttachEvent="onfocus:_cycleFocus;" tabindex="0"></span>
</div>
",
+               templateString:"<div class="dijitDialog">
		<div dojoAttachPoint="titleBar" class="dijitDialogTitleBar" tabindex="0" waiRole="dialog" title="${title}">
		<span dojoAttachPoint="titleNode" class="dijitDialogTitle">${title}</span>
		<span dojoAttachPoint="closeButtonNode" class="dijitDialogCloseIcon" dojoAttachEvent="onclick: hide">
			<span dojoAttachPoint="closeText" class="closeText">x</span>
		</span>
	</div>
		<div dojoAttachPoint="containerNode" class="dijitDialogContent"></div>
	<span dojoAttachPoint="tabEnd" dojoAttachEvent="onfocus:_cycleFocus;" tabindex="0"></span>
</div>
",
 
                // title: String
                //              Title of the dialog

Change History (4)

comment:1 Changed 12 years ago by bill

Milestone: 1.0
Owner: changed from bill to itorrey

Or maybe it's that way on purpose, to reuse the existing CSS rule. In any case, tundra.css defines dijitDialogContent although no one is using it, so something has to change.

comment:2 Changed 12 years ago by guest

I would certainly choose to have the explicit dijitDialogContent class since the styling I've got for titlePane's differs from Dialog's. I would need clever (hackish) CSS selectors to get the styling I need otherwise.

In any case though, I agree it's misleading to supply the style definition for the class and then not use it where logical to do so.

comment:3 Changed 12 years ago by dante

Owner: changed from itorrey to dante
Status: newassigned

i'll double check this during icon unity / template unity

comment:4 Changed 12 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [9703]) incremental checkin refs #3661 (unify icons)

and fixes #3796, #3790, #3656, #3626, #3512, #3789, #3668 via various Input elemet styles, tundra cleanups, tabContainer changes, and more ...

Note: See TracTickets for help on using tickets.