Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#3655 closed defect (fixed)

InlineEditBox keyboard support (for autosave=true)

Reported by: ptbrunet Owned by: ptbrunet
Priority: high Milestone: 0.9
Component: Accessibility Version: 0.9
Keywords: Cc: Becky Gibson
Blocked By: Blocking:

Description (last modified by bill)

This happened after #9508 which removed the cancel and save buttons on InlineEditBoxes wrapping <input> tags...

Use the InlineEditBox test and the first InlineEditBox widget, press enter on it to open the edit box, don't make a change, press tab to leave the edit box, the edit box stays open.

Tabbing out or hitting enter should save the text (if it has changed). ESC should cancel the edit, reverting to the old value.

I think the tabbing part will be fixed by #3648, but we need handling for ENTER and ESC.

Change History (5)

comment:1 Changed 12 years ago by ptbrunet

Component: DijitAccessibility
Milestone: 0.9

comment:2 Changed 12 years ago by bill

Description: modified (diff)
Summary: Open inline edit box, don't make change, tab out, edit box stays openInlineEditBox keyboard support (for autosave=true)

comment:3 Changed 12 years ago by bill

Description: modified (diff)

comment:4 Changed 12 years ago by bill

Resolution: fixed
Status: newclosed

(In [9636]) Bunch of fixes for keyboard support in InlineEditBox?.

Fixes #3482: missing focus events when using InlineEditBox? Accessibility Fixes #3648: Regression in [9508]: no cancelling if autoSave=true (added support for the Esc key.) Fixes #3655: Open inline edit box, don't make change, tab out, edit box stays open Fixes #3674: pressing tab on an open autosave widget should move focus to next widget

Patch from Pete Brunet (IBM, CCLA on file)

comment:5 Changed 12 years ago by bill

(In [9637]) Prevent strange error about "]". Removed the onClick(/*Event*/ evt) callback. (If we need a callback when editing is started should probably be called something different, and doesn't need to be passed the event object.) Refs #3482, #3648, #3655, and #3674.

Note: See TracTickets for help on using tickets.