Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#3645 closed defect (fixed)

TitlePane: loading from URL doesn't work

Reported by: bill Owned by: bill
Priority: high Milestone: 0.9
Component: Dijit Version: 0.9
Keywords: Cc: dante
Blocked By: Blocking:

Description

In test_TitlePane.html the pane that loads from a URL doesn't work. It needs to wait for the data to finish loading and then expand.

Change History (5)

comment:1 Changed 12 years ago by dante

(In [9514]) link for href="" TitlePane? in test is 404. refs #3645 but still does not load from URL, no ContentPane? mixin. [has CP been fully ported to dijit?]

comment:2 Changed 12 years ago by tk

Cc: dante added

If its like TooltipDialog?, you have to rough it up a little bit for it to work... Search "TooltipDialog?" on dtk site and you will find the work around I found for TooltipDialog? to work with href's.

comment:3 Changed 12 years ago by bill

Resolution: fixed
Status: newclosed

(In [9849]) Fixes for TitlePane? url support.

The code in ContentPane? to connect to StackContainer?'s selectChild topic was too specialized. It didn't work for TitlePane?. (For TitlePane? we also need to defer the href load until the pane is opened.) Changed StackContainer? to call Widget.onShow() (if such a method exists) when a pane is selected, and TitlePane? to do the same when it's content is opened. Made TitlePane? extend ContentPane?.

As a side effect this means that <div dojoType=dijit.layout.ContentPane? href=...></div> *not* inside of a StackContainer? won't load the data at all... you have to set preload=true. But that seems like an uncommon case, as it would have been more efficient to just inline the data and avoid the immediate extra trip to the server.

The href for AccordionPane? won't work correctly until AccordionPane? extends ContentPane? (refs #3529)

Fixes #3645 (but I still need to add code to make the animation smoother when the href load is delayed).

comment:4 Changed 12 years ago by bill

(In [9851]) Fix *re*-execution of animations with start/end points specified as functions. The function references were getting overwritten on the first execution.

Various fixes to wipeIn()/wipeOut(): since the start/end points are read in _base/fx.js's beforeBegin(), and that function is called before fx.js's beforeBegin(), we can't set start/end in fx.js's beforeBegin().

Changed TitlePane?'s wipeIn/wipeOut to work on node w/no padding or border. Otherwise setting height=1px will actually set height to 21px on firefox (because height is just the content height).

Overrode TitlePane?.setContent() to animate height change, so that when an href loads it has a smooth expand.

Seeing weird problem w/scrollbars on firefox. Needs to be investigated. Also, IE closes instantly rather than wiping out (bug where dojo.style(node, "height") returns 0 on IE on visible node with height:auto)

Refs #3645

comment:5 Changed 12 years ago by bill

(In [9852]) Fix weird problem w/scrollbars on TitlePane? on firefox. Refs #3645

Note: See TracTickets for help on using tickets.