Opened 12 years ago

Closed 12 years ago

#3620 closed defect (fixed)

Exception thrown in Firefox 2 when opening the root context menu with keyboard

Reported by: simonjb Owned by: sjmiles
Priority: high Milestone: 0.9
Component: Dijit Version: 0.9
Keywords: Cc: Becky Gibson
Blocked By: Blocking:

Description (last modified by simonjb)

To reproduce:

  1. open dijit/tests/test_Menu.html in Firefox 2
  2. press shift-f10

Expected:

  • menu to open

Actual:

  • Exception "Could not convert JavaScript argument" nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"

Change History (6)

comment:1 Changed 12 years ago by simonjb

Description: modified (diff)
Summary: Exception thrown when opening the root context menu with keyboardException thrown in Firefox 2 when opening the root context menu with keyboard

comment:2 Changed 12 years ago by simonjb

Thrown by getComputedStyle() in dojo/_base/html.js. Investigating.

comment:3 Changed 12 years ago by simonjb

The Exception is thrown whenever dojo.getComputedStyle() is called on an HTMLDocument. The Exception is thrown by this line:

return dv.getComputedStyle(node, null);

where dv = document.defaultView

The trace goes like this:

  • Menu._openMyself(): e.target=HTML Element
  • dojo.coords(): node=HTML Element
  • dojo.getComputedStyle(): node=HTML Element
  • dojo._getMarginBox(): calls gcs(p) with p=HTMLDocument (where gcs is dojo.getComputedStyle and p is node.parentNode)
  • dojo.getComputedStyle(): node=HTMLDocument
  • Exception

comment:4 Changed 12 years ago by simonjb

Owner: changed from bill to sjmiles

I've been chatting with sjmiles and he is going to take a look at this.

comment:5 Changed 12 years ago by sjmiles

(In [9477]) Prevent _getMarginBox and _sumAncestorProperties from calling getComputedStyle on non style-bearing objects (i.e. document). Refs #3620.

comment:6 Changed 12 years ago by simonjb

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.