Opened 12 years ago

Closed 12 years ago

Last modified 8 years ago

#3609 closed task (fixed)

Textbox widgets: make onChange fire when user is finished changing value

Reported by: bill Owned by: Douglas Hays
Priority: high Milestone: 0.9
Component: Dijit - Form Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

For Textbox, ValidationTextbox, and related widgets (especially DateTextBox), onChange() should only be called when

  • the value has changed

AND you have "finished entering the value", which means concretely:

  • when widget blurs because
    • you tabbed away
    • you clicked another field or a blank area of the screen
  • when you select a date from the calendar drop down

But, the validation checks (which make the box turn yellow when you have typed something invalid) should happen on every keystroke, so there needs to be some refactoring. (The listenOnKeyPress flag should be removed and assumed to be always true.)

Change History (6)

comment:1 Changed 12 years ago by bill

Description: modified (diff)
Summary: Textbox widgets: make onValueChanged fire when user is finished changing valueTextbox widgets: make onChange fire when user is finished changing value

comment:2 Changed 12 years ago by Douglas Hays

Status: newassigned

comment:3 Changed 12 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

(In [9601]) Fixes #3609. Added intermediateChanges boolean to control onChange frequency. Added priorityChange boolean to setValue to indicate if onChange should be called.

comment:4 Changed 12 years ago by Douglas Hays

(In [9609]) References #3609. Make ComboBox? work by forcing onChange to fire.

comment:5 Changed 12 years ago by bill

(In [10431]) Set incrementalChanges=true for sliders in GFX demos, to work like they used to. Refs #3609.

comment:6 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.