Opened 12 years ago

Closed 11 years ago

#3586 closed defect (fixed)

Tab close buttons not showing up on IE6

Reported by: bill Owned by: Sam Foster
Priority: high Milestone: 1.2
Component: Dijit Version: 0.9
Keywords: Cc: dante
Blocked By: Blocking:

Description

Related to #3398? Just try test_Tabcontainer.html on IE6 (and look at "Tab 3" in second TabContainer?).

Attachments (3)

tabcontainer_sfoster_20070721.patch (3.4 KB) - added by Sam Foster 12 years ago.
changes: tundra.css, one line change to TabContainer?.js, adding close buttons in all alignments in test (CLA on file)
ie6Left.png (5.4 KB) - added by bill 11 years ago.
IE6 tabs on left
safariLeft.png (10.9 KB) - added by bill 11 years ago.
safari tabs on left

Download all attachments as: .zip

Change History (9)

comment:1 Changed 12 years ago by Sam Foster

Owner: changed from bill to Sam Foster

Changed 12 years ago by Sam Foster

changes: tundra.css, one line change to TabContainer?.js, adding close buttons in all alignments in test (CLA on file)

comment:2 Changed 12 years ago by Sam Foster

Cc: bill@… dante@… added
Status: newassigned

tabcontainer_sfoster_20070721.patch includes:

  • TabContainer?.js - in postCreate I add a dijitClosable class to the innerDiv if its closable.
  • tundra.css - different treatment for close buttons on tabs, using positioning. Also fixed up the close button for all alignments top/right/bottom/left (not sure this had a ticket?)
  • test_TabContainer.html - just added close buttons to tabs in the different alignments to test the above.

comment:3 Changed 12 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [9741]) patch from sfoster [cla] fixes #3586 (ie6 tab close icon) with some css-foo and re-instates working hoverstate for closenode ...

comment:4 Changed 12 years ago by dante

(In [9742]) refs #3586 - forgot to sync left and bottom aligned closenode icons (centered on line more or less rather than absolute corner)

Changed 11 years ago by bill

Attachment: ie6Left.png added

IE6 tabs on left

Changed 11 years ago by bill

Attachment: safariLeft.png added

safari tabs on left

comment:5 Changed 11 years ago by bill

Cc: dante added; bill@… dante@… removed
Milestone: 0.91.3
Resolution: fixed
Status: closedreopened

Actually not completely fixed, see http://download.dojotoolkit.org/release-1.1.0/dojo-release-1.1.0/dijit/tests/layout/test_TabContainer.html

The left TabContainers should have a close icon next to Tab 2:

safari tabs on left

However, on IE6, it doesn't appear:

IE6 tabs on left

Strangely, it does work in RTL mode, although I guess that's not too surprising given all the special code added for RTL mode, see #5752.

comment:6 Changed 11 years ago by bill

Milestone: 1.31.2
Resolution: fixed
Status: reopenedclosed

This is working now, although the test has been redesigned so the tab labels are longer. Not sure if that's related. Anyway I'm marking it as fixed.

Note: See TracTickets for help on using tickets.