Opened 12 years ago

Closed 12 years ago

#3576 closed defect (fixed)

inline editbox sav button should have proper state

Reported by: Becky Gibson Owned by: ptbrunet
Priority: high Milestone: 0.9
Component: Accessibility Version: 0.9
Keywords: Cc: Becky Gibson
Blocked By: Blocking:

Description (last modified by Becky Gibson)

The save button is disabled until the user actually makes a change to the data. This button should be marked as disabled=true when it is disabled and then updated with disabled=false when it becomes active. These are standard HTML buttons so can probably use the disabled HTML propertly

Change History (4)

comment:1 Changed 12 years ago by Becky Gibson

Description: modified (diff)
Summary: inline editbox buttons should have ARIA roles and statesinline editbox sav button should have proper state

comment:2 Changed 12 years ago by ptbrunet

The logic appears to be OK. I believe it's a Firefox bug. It works OK in IE6, i.e. a disabled button doesn't get a tab stop and has an MSAA state of UNAVAILABLE. On Firefox 2 and also FF3 trunk, disabled buttons have a tab stop and a state of FOCUSABLE. There is a disabled button in dijit/tests/form/test_Button.html for testing purposes.

comment:3 Changed 12 years ago by ptbrunet

The focusNode is on the span for the text inside the button, not the button itself so the button node never gets disabled. Moving the focus node up one level fixes the problem. Sending a patch.

comment:4 Changed 12 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [9656]) Fixes #3576. Proxy commit for peteb. Move focusNode to button element.

Note: See TracTickets for help on using tickets.