AccordionContainer: refactor Accordion to reuse more Stack code (see TabContainer)

[davidb]

reopening for consideration for 1.1 since accordion and tab container share so much of the same behavior. Is also somewhat related to #4678

[Adam Peller]

davidb, the recent AccordionContainer? refactor sought to do just that. There isn't a lot left to Accordion. could you be more specific?

[davidb]

I was thinking that there is some similar code (e.g. key handling) between the StackController? and AccordionContainer?. I'm not sure we want to refactor Accordion to use the MVC pattern or not. It seems like it might just add complexity. But then, TabContainer? and AccordionContainer? are so similar... it kind of begs the question as to why the implementation is so different. I'm flip flopping.

Maybe Accordion should be left alone. I just wanted to throw this out there to see if you or Bill had thoughts.

If we added the ability to close accordion pages... well.

Feel free to close.

[bill]

Hmm, I took a look at the keyboard code; there isn't that much. But maybe StackController? and AccordionContainer? could share some mixin code. But I'm dubious of the utility to. You can try it and see if it makes sense.

I suppose it's similar to Menu also, especially given the assumption that Toolbar will eventually descend from Menu.

[davidb]

Closing as wontfix.

[davidb]

(In [10865]) Removed unused variable. Refs #3556