Opened 12 years ago

Closed 9 years ago

#3556 closed defect (wontfix)

AccordionContainer: refactor Accordion to reuse more Stack code (see TabContainer)

Reported by: davidb Owned by: davidb
Priority: high Milestone: future
Component: Dijit Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Becky Gibson)

reopening for consideration for 1.1 since accordion and tab container share so much of the same behavior. Is also somewhat related to #4678

Change History (10)

comment:1 Changed 12 years ago by Adam Peller

Owner: changed from bill to Adam Peller

davidb, the recent AccordionContainer? refactor sought to do just that. There isn't a lot left to Accordion. could you be more specific?

comment:2 Changed 12 years ago by davidb

I was thinking that there is some similar code (e.g. key handling) between the StackController? and AccordionContainer?. I'm not sure we want to refactor Accordion to use the MVC pattern or not. It seems like it might just add complexity. But then, TabContainer? and AccordionContainer? are so similar... it kind of begs the question as to why the implementation is so different. I'm flip flopping.

Maybe Accordion should be left alone. I just wanted to throw this out there to see if you or Bill had thoughts.

If we added the ability to close accordion pages... well.

Feel free to close.

comment:3 Changed 12 years ago by bill

Owner: changed from Adam Peller to davidb

Hmm, I took a look at the keyboard code; there isn't that much. But maybe StackController? and AccordionContainer? could share some mixin code. But I'm dubious of the utility to. You can try it and see if it makes sense.

I suppose it's similar to Menu also, especially given the assumption that Toolbar will eventually descend from Menu.

comment:4 Changed 12 years ago by davidb

Resolution: wontfix
Status: newclosed

Closing as wontfix.

comment:5 Changed 11 years ago by Becky Gibson

Description: modified (diff)
Milestone: 1.01.1
Resolution: wontfix
Status: closedreopened

comment:6 Changed 11 years ago by davidb

(In [10865]) Removed unused variable. Refs #3556

comment:7 Changed 11 years ago by simonjb

Milestone: 1.11.2

comment:8 Changed 11 years ago by bill

Milestone: 1.21.4
Summary: refactor: Accordion could reuse more Stack code (see TabContainer)AccordionContainer: refactor Accordion to reuse more Stack code (see TabContainer)

comment:9 Changed 10 years ago by bill

Milestone: 1.4future

comment:10 Changed 9 years ago by bill

Resolution: wontfix
Status: reopenedclosed
Note: See TracTickets for help on using tickets.