Opened 12 years ago

Closed 12 years ago

#3552 closed defect (fixed)

Refactor/clean-up html.js

Reported by: sjmiles Owned by: sjmiles
Priority: high Milestone: 0.9beta
Component: General Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

html.js has gathered moss over the last few months. Various clean up tasks are needed.

Change History (5)

comment:1 Changed 12 years ago by sjmiles

Status: newassigned

comment:2 Changed 12 years ago by sjmiles

(In [9341]) Refactoring of html.js. Refs #3552.

comment:3 Changed 12 years ago by sjmiles

Various tasks were performed in r9341, including:

  • _setContentBox renamed _setContentSize. Left/top are ill-defined in this context.
  • contentBox in "setting mode" therefore now ignores left/top.
  • _getPadBounds renamed _getPadExtents for consistency.
  • _getBorderExtents and _getBorderBox added.
  • factored _usesBorderBox test into a function
  • adjusted various methods for browser quirks, documented inline

Refer also to #3454 and #3515.

comment:4 Changed 12 years ago by sjmiles

Sorry, failed to preview my bullet points above. Repaired edition:

  • _setContentBox renamed _setContentSize. Left/top are ill-defined in this context.
  • contentBox in "setting mode" therefore now ignores left/top.
  • _getPadBounds renamed _getPadExtents for consistency.
  • _getBorderExtents and _getBorderBox added.
  • factored _usesBorderBox test into a function
  • adjusted various methods for browser quirks, documented inline

comment:5 Changed 12 years ago by sjmiles

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.