Opened 12 years ago

Closed 12 years ago

#3544 closed task (fixed)

consolidate ESC key handling in dijit.util.popup

Reported by: bill Owned by: Becky Gibson
Priority: high Milestone: 0.9
Component: Accessibility Version: 0.9
Keywords: Cc: simonjb
Blocked By: Blocking:

Description

I think when a popup/dropdown is showing, dijit.util.popup can register a listener for the ESC key, and then when it gets it, call dijit.util.popup.closeAll(). Same way that clicking somewhere random on the screen closes all the popups.

Then remove ESC handling code from whatever uses dijit.util.popup (Menu, DropdownButton?, ComboBox?, etc.)

Change History (5)

comment:1 Changed 12 years ago by Becky Gibson

Cc: simonjb added

I'm not sure we want to closeAll because within a menu pressing escape only closes the current submenu - not all of the menus.

comment:2 Changed 12 years ago by bill

Ah Becky is right. Just want to close one level (dijit.util.popup.close()) in this case.

comment:3 Changed 12 years ago by bill

(In [9635]) Patch from Becky: Consolidate escape handling to close popup in popup.js. Make necessary changes to buttons and menu. Need to do additional work for combox and select so not closing the issue. refs #3544. Required some changes to dropdownButton and combobutton that also refs #3595.

comment:4 Changed 12 years ago by bill

(In [9639]) Oops, declaration has to come earlier. Refs #3544.

comment:5 Changed 12 years ago by Becky Gibson

Resolution: fixed
Status: newclosed

(In [9713]) fixes #3544. Focus goes to arrow portion of combobutton when close drop down item via escape key. Changed focusNode on combobutton template. Removed comments to fix focus from button.js. Combobox and filteringselect will do all of the keyboard handling rather than relying on popup default key handling.

Note: See TracTickets for help on using tickets.