[patch][cla] event.connect breaks with undefined first argument

[david]

This attaches to window:

dojo.event.connect(undefined, "onclick", dojo, "debug");

Outputs DEBUG: [object MouseEvent] when I click anywhere on the page.

If you have:

dojo.event.connect(undefined, "onclick", dojo.debug);

It doesn't throw any errors but I don't know where that gets connected as it doesn't fire.

[guest]

Since undefined is not an object or string, current interpolateArgs implementation does not cover this corner situation.

[Eugene Lazutkin]

1st case: most probably we should guard against "undefined" and throw an exception for such connects. Or ignore it. I would prefer the 1st option because a programmer made a mistake during calculation of parameters.

2nd case: typeof(dojo.debug) is "function", and dojo.debug instanceof Function is True. :-( You can even call it but this is not going to be set. So my guess is true methods will blow up on event but I don't see how we can distinguish this (clearly wrong) case from legitimate function parameters.

[bookstack]

Another patch regarding the feedback from the community, esspecially elazutkin

[bookstack]

The new attachment event.js.353.patch would not mimic the default behavior if an undefined object is used, it would throw exceptions in all corner cases. Here is a test case for it as well.

[bookstack]

The test cases for #353

[bill]

seems like a lot of code to add to catch a user error; i don't think it's worth it. anyway, i'll defer to 0.5 and we can think about it then.

[tk]

Maybe we should get Alex involved in this discussion, I would imagine this has been resolved (or maybe its an edge case that David found) since I havent seen any buzz on the ML or forums regarding this type of bug...

Trying to clean up the trac DB...

-Karl

[sjmiles]

0.9 analog dojo.connect requires a non-null first argument and will throw an exception on detectably bad input.