Opened 12 years ago

Closed 12 years ago

#3529 closed defect (fixed)

AccordionPane should extend ContentPane

Reported by: Adam Peller Owned by: bill
Priority: high Milestone: 0.9
Component: Dijit Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

so that panes may have hrefs and so that loading can be deferred until pane is shown

Likely means removing onSelected() method and invocation added in #2488

Change History (4)

comment:1 Changed 12 years ago by bill

(In [9849]) Fixes for TitlePane? url support.

The code in ContentPane? to connect to StackContainer?'s selectChild topic was too specialized. It didn't work for TitlePane?. (For TitlePane? we also need to defer the href load until the pane is opened.) Changed StackContainer? to call Widget.onShow() (if such a method exists) when a pane is selected, and TitlePane? to do the same when it's content is opened. Made TitlePane? extend ContentPane?.

As a side effect this means that <div dojoType=dijit.layout.ContentPane? href=...></div> *not* inside of a StackContainer? won't load the data at all... you have to set preload=true. But that seems like an uncommon case, as it would have been more efficient to just inline the data and avoid the immediate extra trip to the server.

The href for AccordionPane? won't work correctly until AccordionPane? extends ContentPane? (refs #3529)

Fixes #3645 (but I still need to add code to make the animation smoother when the href load is delayed).

comment:2 Changed 12 years ago by bill

Milestone: 0.91.0

comment:3 Changed 12 years ago by bill

Milestone: 1.00.9
Owner: changed from Adam Peller to bill
Status: newassigned

comment:4 Changed 12 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [10247]) Fixes #3529: AccordionPane? should extend ContentPane?

Note: See TracTickets for help on using tickets.