Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#3510 closed enhancement (fixed)

Consider to implement a way to require dojo.parser without getting a page scan

Reported by: mumme Owned by: alex
Priority: high Milestone: 0.9beta
Component: Core Version: 0.9
Keywords: dojo.parser, 4dijit, parser Cc:
Blocked By: Blocking:

Description

All widgets that mixins dijit._Templated requires dojo.parser.

I think it is a bad decision to have the autoparse part in the same file as the parser.

I think a user should be able to require a dijit widget, like for instance a dijit.form.Button, without getting a implicit page scan.

Having discussed it with Bill in a mail conversation, he didn't like dijit.parser because that would add a dijit dependency.

I think the simplest sollution would be to split the 4 rows that auto starts the parser into a separate file

Some suggestions: dojo.autoparse dojo.createwidgets dojo.widgetscan

Regards

Fredrik Johansson

Change History (9)

comment:1 Changed 12 years ago by bill

Owner: changed from bill to alex

Alex, what do you think? I thought of a startup parameter (like isDebug=true), so as to avoid yet another file.

comment:2 Changed 12 years ago by alex

I agree that we should avoid another file, but I'm not sure that Templated isn't to blame here. I'm OK w/ a djconfig param, but perhaps it should be used to turn full-page parse onload ON and not off. That way there's no question about whether dijit should pull in the parser (it clearly should). Just whether or not the full page parse should happen as a result.

Bill, what do you think?

comment:3 Changed 12 years ago by bill

I'm OK w/that. I don't have a strong opinion on it.

comment:4 Changed 12 years ago by alex

Status: newassigned

comment:5 Changed 12 years ago by mumme

I'm happy with whatever solution you might find as long as it makes it possible to require the parser without getting the page scan

I guess you think that this is a bit to mush for our users?

dojo.require('dojo.parser');
dojo.addOnLoad(function(){
  dojo.parser.parse();
});

comment:6 Changed 12 years ago by bill

Keywords: 4dijit added; dijit removed

comment:7 Changed 12 years ago by alex

Resolution: fixed
Status: assignedclosed

(In [9408]) implement djConfig.parseOnLoad param. Move tests to use parseOnLoad to signify that they want/need full page parsing onload. Lots of hygene fixes for the dijit test pages. Fixes #3510

comment:8 Changed 12 years ago by bill

(In [9419]) Missed files w.r.t. parseOnLoad flag. Refs #3510.

comment:9 Changed 12 years ago by dante

(In [9424]) fixing dojox parseOnLoad references. refs #3510 note: dojox tests need cleanup, too. will probably find more when cleaning, out of time for now.

Note: See TracTickets for help on using tickets.