Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#3478 closed task (fixed)

Dijit: clean up base class hierarchy/naming

Reported by: bill Owned by: bill
Priority: high Milestone: 0.9beta
Component: Dijit Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

Clean up the base class hierarchy before beta.

  • dijit.base.Sizable can be rolled into dijit.base.Layout
  • FormElement should be in form/ directory (named _something)?
  • dijit.base.Layout should be in layout directory (named _something)?
  • probably Dialog and TitlePane shouldn't be in layout directory since they aren't part of the hierarchy of nested widgets where one pane contains multiple subpanes (Tabs, Accordion, SplitContainer, LayoutContainer)
  • LayoutContainer is also a strange name since *all* of the widgets mentioned above are layout containers.

Change History (11)

comment:1 Changed 12 years ago by bill

Status: newassigned

comment:2 Changed 12 years ago by bill

(In [9227]) Roll dijit.base.Sizable into dijit.base.Layout. Refs #3478.

comment:3 Changed 12 years ago by bill

(In [9247]) Move Dialog from dijit.layout into dijit, since it isn't really a layout widget. Refs #3478.

comment:4 Changed 12 years ago by bill

(In [9248]) Move dijit.base.FormElement? to dijit.form._FormWidget, to match style of other base classes (next will move dijit.base.LayoutWidget?). Refs #3478.

comment:5 Changed 12 years ago by bill

(In [9249]) Move dijit.base.LayoutWidget? to dijit.layout._LayoutWidget, to match style of other base classes. Refs #3478.

comment:6 Changed 12 years ago by bill

(In [9250]) Since all the form widgets mixin TemplatedWidget?, just make _FormWidget inherit TemplatedWidget?. Refs #3478.

comment:7 Changed 12 years ago by bill

(In [9251]) Make layout._LayoutWidget extend base.Widget. Refs #3478.

comment:8 Changed 12 years ago by bill

(In [9252]) Move remaining dijit.base widgets/mixins to dijit, to match style of other base classes:

dijit.base.Widget --> dijit._Widget dijit.base.TemplatedWidget? --> dijit._Templated dijit.base.Container --> dijit._Container

Refs #3478.

comment:9 Changed 12 years ago by bill

(In [9253]) Delete emptied dir.

Refs #3478.

comment:10 Changed 12 years ago by bill

Resolution: fixed
Status: assignedclosed

comment:11 Changed 12 years ago by Adam Peller

(In [9258]) Missing require of dijit._Widget. Refs #3478

Note: See TracTickets for help on using tickets.