#3473 closed defect (fixed)
ComboBox (dojo 4.2) IE7 Error on Select
Reported by: | guest | Owned by: | haysmark |
---|---|---|---|
Priority: | high | Milestone: | 0.9 |
Component: | Dijit - Form | Version: | 0.4.2 |
Keywords: | ComboBox | Cc: | |
Blocked By: | Blocking: |
Description
In _performSearch, from line 223 comes this: ==========================================================================
var dataLabel = new String((!this.caseSensitive) ? this._data[x][0].toLowerCase() : this._data[x][0]);
if(dataLabel.length < searchStr.length){
this won't ever be a good search, will it? What if we start to support regex search? continue;
}
========================================================================= IE 7 complained about this._data[x][0] being "null or not a value", so a proposed fix would be:
========================================================================= if (this._data[x]) {
var dataLabel = new String((!this.caseSensitive) ? this._data[x][0].toLowerCase() : this._data[x][0]);
if(dataLabel.length < searchStr.length){
this won't ever be a good search, will it? What if we start to support regex search? continue;
}
}
Change History (3)
comment:1 Changed 14 years ago by
Component: | General → Dijit |
---|---|
Milestone: | → 0.9 |
Owner: | changed from anonymous to haysmark |
comment:2 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Right, all of that toLowerCase code is gone, and 0.9 does a better job of null checking like you suggested.
comment:3 Changed 10 years ago by
Component: | Dijit → Dijit - Form |
---|
I suspect this is no longer relevant with the 0.9 code?