ComboBox (dojo 4.2) IE7 Error on Select

[guest]

In _performSearch, from line 223 comes this: ==========================================================================

var dataLabel = new String((!this.caseSensitive) ? this._data[x][0].toLowerCase() : this._data[x][0]);

if(dataLabel.length < searchStr.length){

this won't ever be a good search, will it? What if we start to support regex search? continue;

}

========================================================================= IE 7 complained about this._data[x][0] being "null or not a value", so a proposed fix would be:

========================================================================= if (this._data[x]) {

var dataLabel = new String((!this.caseSensitive) ? this._data[x][0].toLowerCase() : this._data[x][0]);

if(dataLabel.length < searchStr.length){

this won't ever be a good search, will it? What if we start to support regex search? continue;

}

}

[bill]

I suspect this is no longer relevant with the 0.9 code?

[haysmark]

Right, all of that toLowerCase code is gone, and 0.9 does a better job of null checking like you suggested.