Opened 12 years ago

Closed 12 years ago

#3462 closed defect (fixed)

ValueChanged events: make sure fully specified (and implemented properly)

Reported by: davidb Owned by: bill
Priority: high Milestone: 0.9
Component: Dijit Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

Make sure we have a full plan for valuechanges in (at least) Form widgets.

Specs go here: dojotoolkit.org/developer/dijit/spec

Change History (7)

comment:1 Changed 12 years ago by davidb

Owner: changed from davidb to bill

Reassigning to bill while its fresh on his mind. Feel free to reassign back.

comment:2 Changed 12 years ago by bill

Right... I'm thinking that all widgets have an onChange() event that is called when:

  • checkbox/radio/toggle button: whenever you click to change the value
  • filteringSelect: whenever you select a value, but *not* as you press the down arrow key to cycle through values
  • input boxes (validationTextBox), combobox: when you tab away or click another field
  • DateTextBox?: when you tab away or click something on the calendar

Not sure what the arguments are to onChange(). maybe a pointer to the widget itself, or the new value, or {value: "foo", oldValue: "bar"}

The input text box widgets could also have an onInput() method.

Not sure if all that is possible, but I hope so.

comment:3 Changed 12 years ago by bill

Status: newassigned

comment:4 Changed 12 years ago by alex

Milestone: 0.9beta0.9

as per discussion w/ bill, moving to 0.9 final.

comment:5 Changed 12 years ago by bill

(In [9446]) Just moved the value field (reporting the value of the FilteringSelect?) to the right, so that it's easy to see when the onValueChanged event happens. (It happens when I want, only when you blur the field, not on every keystroke) Refs #3462.

comment:6 Changed 12 years ago by bill

I split this bug into separate items. See #3609 (for textbox and validation textbox related widgets), and #3610 for TextArea?, and #3611 for Spinner/Slider?. FilteringSelect? already does what I want (see [9446]). Leaving this bug open to deal with checkbox/radio, and to think about if I want to change the name of onValueChanged to onChange.

comment:7 Changed 12 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [9448]) Name callback onChange(), rather than onValueChanged(), since onChange() is an HTML standard. Refs #3288, and fixes #3462.

Note: See TracTickets for help on using tickets.