FilteringTable sortFunction is unused

[guest]

Hi, I'm using version 0.4.3 of dojo. The FilteringTable? has an attribute called sortusing, to declare the function to sort the rows. This functio is never called. In my case i patch the function 'createSortFunction' like this

function createSortFunction(fieldIndex, dir) {
		var meta = self.columns[fieldIndex];
		var field = meta.getField();

        

        if( meta.sortFunction != null ) {

            

            return function (rowA, rowB) {

                

    			if (dojo.html.hasAttribute(rowA, "emptyRow") ) 

				    return 1;

			

			    if (dojo.html.hasAttribute(rowB, "emptyRow")) 

				    return -1;

			

			    var a = self.store.getField(self.getDataByRow(rowA), field);

			    var b = self.store.getField(self.getDataByRow(rowB), field);

			    

                return dir * meta.sortFunction(a,b);

            }

        }

        
		return function (rowA, rowB) { ...

and it works fine.

[guest]

Replying to guest:

Hi, I'm using version 0.4.3 of dojo. The FilteringTable? has an attribute called sortusing, to declare the function to sort the rows. This functio is never called. In my case i patch the function 'createSortFunction' like this

function createSortFunction(fieldIndex, dir) {
		var meta = self.columns[fieldIndex];
		var field = meta.getField();

        

        if( meta.sortFunction != null ) {

            

            return function (rowA, rowB) {

                

    			if (dojo.html.hasAttribute(rowA, "emptyRow") ) 

				    return 1;

			

			    if (dojo.html.hasAttribute(rowB, "emptyRow")) 

				    return -1;

			

			    var a = self.store.getField(self.getDataByRow(rowA), field);

			    var b = self.store.getField(self.getDataByRow(rowB), field);

			    

                return dir * meta.sortFunction(a,b);

            }

        }

        
		return function (rowA, rowB) { ...

and it works fine.

Hi. I had the same problems with dojo-0.4.3. I patched the createSorter-function a bit different for own sortFunctions like dateSorter or floatSorter. The attached file is my patch for discussion.

Rolf Metternich

[Tom Trenka]

Filtering is dead, long live the king!

[(none)]

Milestone 0.4 deleted