Opened 12 years ago

Closed 12 years ago

#3448 closed defect (fixed)

ContentPane fails a lot of dijits(this time I attach test files)

Reported by: guest Owned by: bill
Priority: high Milestone: 1.0
Component: Dijit Version: 0.9
Keywords: ContentPane dijit Cc:
Blocked By: Blocking:

Description

sorry that I have to reopen a ticket in this way,because I have no right to reopened it in common way.I think it's a bug and not my mistake. I attach two files. the testContentPaneWithTabContainer.html will show you how the same tabContainer works outside a contentPane and fails in a contentPane.When it's in a contentPane,the tab's position can't works.

the testContentPaneAccordion.html will show you how the same accordion fails in a contentPane and works in a <div></div>.When it's in a contentPane,the accordion can't expand.

both file you can run under a directory like this: dojo/

dojo.js

mydir/

myfile.html

Attachments (2)

testContentPaneWithTabContainer.html (2.3 KB) - added by guest 12 years ago.
testContentPaneAccordion.html (1.8 KB) - added by guest 12 years ago.

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by guest

Changed 12 years ago by guest

comment:1 Changed 12 years ago by guest

the testContentPaneAccordion.html have a problem in IE.you should run that in firefox

comment:2 Changed 12 years ago by guest

I just found that the origin test file of accordionContainer(dijit/tests/layout/test_AccordionContainer.html) in dojo source fails in IE too!

comment:3 Changed 12 years ago by bill

Ah, ok, thanks for the test case. This is probably the same problem as #3406.

Just need to change getParent() so it only returns something if the parent inherits from Container, I think.

You programatic instantiation of Accordion is a little strange though. You could either call startup() first and then call addChild(), or just create the AccordionPane? children first, then create the parent AccordionContainer?, then call startup(). (No calls to addChild() needed in that case as long as the dom structure is connected)

comment:4 Changed 12 years ago by bill

Milestone: 0.9beta1.0
Priority: highestnormal
severity: majorminor

comment:5 Changed 12 years ago by bill

Resolution: fixed
Status: newclosed

(In [9265]) Make getParent() only return a value if parent is a _Container. This prevents layout widgets from thinking they are being controlled by a parent layout widgets when really they are just floating free inside a ContentPane?.

Fixes #3448, #3406.

Note: See TracTickets for help on using tickets.