Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#3429 closed enhancement (fixed)

[patch] [cla] Tooltip: support multiple node ids in the connectId attribute

Reported by: cameron Owned by: bill
Priority: high Milestone: 1.0
Component: Dijit Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description


Attachments (1)

Tooltip-multiple-connectId.patch​ (3.4 KB) - added by guest 13 years ago.
[email protected]… : adding patch

Download all attachments as: .zip

Change History (5)

Changed 13 years ago by guest

Attachment: Tooltip-multiple-connectId.patch​ added

[email protected]… : adding patch

comment:1 Changed 13 years ago by guest

patch also includes a manual test case in test_Tooltip.html

comment:2 Changed 13 years ago by bill

Component: General → Dijit
Milestone: → 1.0
Owner: changed from anonymous to bill
Reporter: changed from guest to cameron
Summary: Patch for Tooltip to support multiple node ids in the connectId attribute → [patch] [cla] Tooltip: support multiple node ids in the connectId attribute
Type: defect → enhancement

comment:3 Changed 13 years ago by bill

Resolution: → fixed
Status: new → closed

(In [10942]) Fixes #3429: Tooltip: support multiple node ids in the connectId attribute. Patch from Cameron Braid (CLA on file), but I had to update it because it got stale.

comment:4 Changed 12 years ago by bill

(In [16565]) [10942] left the Tooltip API in a confusing state since it converted the connectId parameter (which sounds like a scalar) into an array. For back-compatibility and slightly less confusion, make programmatic instantiation and Tooltip.attr('connectId', ...) accept both arrays and scalars.

For 2.0 I want to just rename that connectId to connectIds, or convert it back to a scalar. (How often do we want a single tooltip for multiple nodes? It seems uncommon.)

Along the way I noticed that Tooltip.attr('connectId', ...) doesn't work correctly since it doesn't erase the old connections. Not sure that's worth supporting anyway though; it too seems quite uncommon.

Refs #3429, fixes #6081 !strict.

Note: See TracTickets for help on using tickets.