regression: drop down vulnerable to space bar selection of menu items

[davidb]

To recreat: in dijit/tests/form/test_Button.html:

In FF2 on windows or linux:

1. tab to the edit drop down button
2. invoke via enter or space key
3. select a menuitem (the default/first one) via space key
4. note the menu re-pops up after closing.

Was fixed but a bit of the work for workaround:3281 done via patch on 3061 seems to have been lost. Will post small workaround patch.

[davidb]

proposed workaround.

[davidb]

Hi Bill, looks like you fixed this in the drop down button? I guess you essentially removed onclick handling which is certainly one approach. Shall we close this one?

[davidb]

On second though, might want to hold off on closing... This fix, coupled with a patch I just posted to ticket #3281 creates a similar problem. It seems both should either activate on the down, OR, the up.

In other words, things should only popup or close on a key down XOR a key up.

[davidb]

a more general fix.

[davidb]

wildbill's input made this fix better :)

[davidb]

(In [9304]) Fixes #3428: onklick now fires on enter-down instead of enter-up to match browser behaviour.

[davidb]

(In [9306]) Refs #3428: updated test for enter-down (was enter-up)

[bill]

(In [9326]) Array.forEach() doesn't work on IE. Use dojo.forEach(). Refs #3428. (Also fixed widget destruction to properly disconnect.)