Opened 12 years ago

Closed 12 years ago

Last modified 8 years ago

#3417 closed defect (fixed)

FilteringSelect tooltip can appear when node un focused

Reported by: bill Owned by: haysmark
Priority: high Milestone: 0.9beta
Component: Dijit - Form Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

This is due to code in FilteringSelect?.js:

47 _callbackSetLabel: function(/*Object*/ result){
...
56 this.validate(true);

The true flag means that the element is in focus, whereas in this case it isn't.

Thus anytime you call setValue()/setDisplayedValue() on a FilteringSelect? (and maybe Combobox too?) the popup will show. Should only show when the node is focused. Code needs to be refactored somehow (probably a change to ValidateTextBox? and FilteringSelect?.) Previously this was happening on page load for themeTester.html.

Change History (5)

comment:1 Changed 12 years ago by dante

don't know which commit fixed it, but I'm not seeing this particular problem anymore ...

please confirm someone?

comment:2 Changed 12 years ago by bill

Description: modified (diff)
Priority: highnormal
Summary: themeTester.html show "please enter valid state" tooltip on page load (upper left corner)FilteringSelect tooltip can appear when node un focused

I'm not seeing this behavior anymore either, but I want to leave the bug open since the code above is almost certainly wrong; anytime you call setValue()/setDisplayedValue() on a FilteringSelect? (and maybe Combobox too?) eventually this.validate(true) will be called, so the popup will show, even if the node isn't focus anymore.

comment:3 Changed 12 years ago by bill

Resolution: fixed
Status: newclosed

(In [9199]) Added a _hasFocus attribute to help FilteringSelect? decide whether to show the tooltip in its callback function. Refactored DateTextbox? code to avoid inheritance issues with this code and [9138]. Updated test_FilteringSelect with two buttons demonstrating setting the value without focus.

Fixes #3417. Patch from Mark Hays (IBM, CCLA on file)

comment:4 Changed 12 years ago by bill

Resolution: fixed

(In [9200]) Added a _hasFocus attribute to help FilteringSelect? decide whether to show the tooltip in its callback function. Refactored DateTextbox? code to avoid inheritance issues with this code and [9138]. Updated test_FilteringSelect with two buttons demonstrating setting the value without focus.

Fixes #3417. Patch from Mark Hays (IBM, CCLA on file)

comment:5 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.