Opened 12 years ago

Closed 12 years ago

#3363 closed defect (fixed)

[doh] util/doh/runner.js may have copy/paste errors: "tests" became "doh"

Reported by: skinner Owned by: alex
Priority: high Milestone:
Component: TestFramework Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

I'm not sure about this, but it looks like there are a number of errors in util/doh/runner.js that resulted from doing a global replace to change "tests" into "doh".

Here's an example of what I think may be an unintended replacement:

doh.registerdoh = function(/*String*/ group, /*Array*/ testArr){
	// summary:
	//		registers a group of doh, treating each element of testArr as
	//		though it were being (along with group) passed to the registerTest
	//		method.
	for(var x=0; x<testArr.length; x++){
		this.registerTest(group, testArr[x]);
	}
}

Maybe that should instead look like this:

doh.registerTests = function(/*String*/ group, /*Array*/ testArr){
	// summary:
	//		registers a group of tests, treating each element of testArr as
	//		though it were being (along with group) passed to the registerTest
	//		method.
	for(var x=0; x<testArr.length; x++){
		this.registerTest(group, testArr[x]);
	}
}

Change History (1)

comment:1 Changed 12 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [9719]) fix some unintentional renames of 'tests' to 'doh'. Fixes #3363

Note: See TracTickets for help on using tickets.