Opened 12 years ago

Closed 12 years ago

#3361 closed defect (fixed)

JsonItemStore unit test data out of sync

Reported by: skinner Owned by: Jared Jurkiewicz
Priority: low Milestone:
Component: Data Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

The unit tests for JsonItemStore? include two copies of the countries.json test data: one copy in the file tests/data/countries.json, and a second copy at the beginning of the file tests/data/JsonItemStore.js.

The test data at the top of the tests/data/JsonItemStore.js file has fallen out of sync with the copy in the tests/data/countries.json file. The countries.json file now specifies a 'label' attribute, but the tests/data/JsonItemStore.js data does not. This may cause the unit tests to fail in a non-browser environment.

The simple fix would be to update the data in the tests/data/JsonItemStore.js file. A better fix would be to somehow make it possible to always read from the countries.json file, even in a non-browser test environment -- but I have no idea what it would take to make that work.

Attachments (1)

dojo.data.tests_20070612.patch (7.1 KB) - added by Jared Jurkiewicz 12 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 12 years ago by Jared Jurkiewicz

Status: newassigned

Ack, missed that.

There's no way I know of to make it always possible to read from the file, unfortunately, in non-browser cases.

Changed 12 years ago by Jared Jurkiewicz

comment:2 Changed 12 years ago by Jared Jurkiewicz

Tested on:

Non-Browser:


The Dojo Unit Test Harness, $Rev$ Copyright (c) 2007, The Dojo Foundation, All Rights Reserved


59 tests to run in 2 groups


GROUP "tests.data.JsonItemStore?" has 41 tests to run


GROUP "tests.data.utils" has 18 tests to run


| TEST SUMMARY:


59 tests in 2 groups 0 errors 0 failures

Browser:

Windows:

IE 6 IE 7 Firefox 2.0.0.4 Firefox 1.5.0.12 Opera 9.2 Seamonkey 1.1.2

OS-X:

WebKit?

comment:3 Changed 12 years ago by Jared Jurkiewicz

Resolution: fixed
Status: assignedclosed

(In [9049]) Updating UT for JsonItemStore?. fixes #3361

Note: See TracTickets for help on using tickets.