FilteringSelect: should call getIdentity()

[bill]

FilteringSelect? should call getIdentity() to get the key for each entry in the drop down list.

Jared has already implemented getIdentity() in JsonItemStore?, so JsonItemStore? should have everything you need. In the unit tests there's a data file that serves as an example of how to specify item labels and item identifiers: ​http://trac.dojotoolkit.org/browser/dojo/trunk/tests/data/countries.json

[Douglas Hays]

(In [9101]) Fixes #3347. Proxy commit for haysmark. If you leave keyAttr blank on a FilteringSelect?, it uses the identifer field from the data.

[bill]

Actually what I meant was to remove the keyAttr column and require that the data store specified implement getIdentity() and getItemByIdentity().

Interface to getItemByIdentity() might be changing to an async fetchItemByIdentity() so let's wait for that to settle. Given the current interface to getItemByIdentity(), you need to test for the item being loaded or not, as per Brian's mail:

function fetchItemByIdentity(id, callback){
    var item = store.getItemByIdentity(id);
    if(store.isItemLoaded(item)){
        callback.call(item);
    }else{
        store.loadItem({item:item, onItem:callback});
    }
} 

[Douglas Hays]

(In [9228]) Fixes #3347. Proxy commit for haysmark. Removed keyAttr from FilteringSelect? (per bill).