Opened 14 years ago
Closed 14 years ago
#3344 closed defect (fixed)
sub-tabs lose rendering on re-display
Reported by: | alex | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 0.9beta |
Component: | Dijit | Version: | 0.9 |
Keywords: | Cc: | alex | |
Blocked By: | Blocking: |
Description
a simple test file is attached. Long story short, just create a set of nested TabContainers?, move from the first to the second outer tab, and then move back. The inner tab container in the first tab does not render its tabs when redisplayed until the window is resized. There seem to be different code paths for resize vs. redisplay. I imagine this is the root of some other niggling layout bugs as well.
Attachments (1)
Change History (4)
Changed 14 years ago by
Attachment: | accordionInTabs.html added |
---|
comment:1 Changed 14 years ago by
Resolution: | → worksforme |
---|---|
Status: | new → closed |
Accordion is pretty broken right now, and also the test file is weird (you should never have an Accordion inside a ContentPane?... the AccordionContainer? itself should be a child of the TabContainer?).
I took the accordion out and tried this test on FF/Mac. It's working for me. Alex, can you find a broken testcase that doesn't involve accordion?
The other thing is that the outer height: 100% doesn't mean anything unless you have
html, body: {height: 100%}
comment:2 Changed 14 years ago by
Resolution: | worksforme |
---|---|
Status: | closed → reopened |
OK, I think I reproduced this in test_TabContainer.html (first tab set).
Problem is that the subTabContainer is trying to size itself while display="none". PageContainer::_transition() --> PageContainer::_showChild() --> calls resize() before show(). Probably should make pane visible:hidden rather than display:none.
comment:3 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
(In [9207]) Remove Showable interface; Dialog and Tooltip are showable, and a menu is openable(), but in general widgets shouldn't support this interface.
TabContainer? and AccordionContainer? will transition their children in a widget specific way.
This checkin also fixes the sub-tabs rendering problems.
simple test file that shows nested tabs rendering incorrectly on redisplay