Opened 12 years ago

Closed 12 years ago

Last modified 10 years ago

#3336 closed defect (fixed)

popup menu showing a large blank box on IE6

Reported by: Douglas Hays Owned by: bill
Priority: high Milestone: 0.9beta
Component: Dijit Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

Revision [8970] has caused a regression with the background iframe created for IE6. Run test_FilteringSelect.html. Resize the browser window so that there's more space above the 1st input box than below it. Click the 1st dropdown arrow button and the popup appears correctly above the box, but a blank box also appears below the box (bad iframe size?).

Change History (4)

comment:1 Changed 12 years ago by bill

Hmm, interesting. The problem is actually that after PopupManager? has shown the popup and sized the background iframe, DropdownTextBox? resizes the popup:

var best=this._popupWidget.open(this);
dojo.marginBox(this._popupWidget.domNode, {h:best.h,w:dojo.marginBox(this.domNode).w});

I think even before the changeset listed above, the iframe was too big, and was making form elements on the page (like <select>) disappear.

The obvious solution is for PopupManager? to attach the iframe as a child of the popup top node, with width=height=100%, but I guess that fails for <table> nodes (like the Calendar widget) which can't have iframes as children. Maybe if PopupManager? creates a wrapper <div> that contains the popup itself, and the iframe.

comment:2 Changed 12 years ago by bill

Resolution: fixed
Status: newclosed

(In [8995]) Refactor and simplify BackgroundIFrame and the code that uses it. Now iframe is always a child of the popup, and automatically adjusts it's size to match the popup. On IE, iframe's size is defined as an expression() on it's parent node. On FF for high contrast mode, iframe's size is width=height=100%.

Fixes #3336.

Still some issues with displaying menu on scrolled window in IE.

comment:3 Changed 12 years ago by bill

(In [8996]) move PopupManager? and BackgroundIframe? into one file called popup.js Refs #3336

comment:4 Changed 12 years ago by bill

(In [9001]) oops, forgot to remove some temporary code for testing; thanks adam!

refs #3336

Note: See TracTickets for help on using tickets.