Opened 12 years ago

Closed 12 years ago

#3333 closed defect (fixed)

last focused item in tree gets lost if close the branch with a mouse

Reported by: Becky Gibson Owned by: davidb
Priority: high Milestone: 0.9beta
Component: Accessibility Version: 0.9
Keywords: Cc: Becky Gibson
Blocked By: Blocking:

Description

if you have focused on a child node of an opened branch and then use the mouse to close the branch the tabindex=0 stays on the now invisible node. Focus should go to the parent of the child and tabindex should be set to -1 on the child and 0 on the now focused node (the parent). This ensures that only visible nodes are in the tab order.

from bill via irc: this should be implemented with dojo.query. when you close a node, just query if any of it's children have tabIndex != -1

Change History (4)

comment:1 Changed 12 years ago by bill

Actually on second thought, should closing/opening a node automatically move focus to that node (regardless of where the current focus is)? I don't know the right answer.

It seems like the above text implies that focus should only change if the currently focused node becomes hidden. (By the way, the text above should probably say "ancestor" rather than "parent", because you could hide a node by closing any one of it's ancestors.

comment:2 Changed 12 years ago by davidb

Status: newassigned

comment:3 Changed 12 years ago by davidb

My patch for this on 3304 only moves focus if it is sitting on a child of the collapsed tree.

comment:4 Changed 12 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [9105]) Fixes for focus/keyboard support for tree. Fixes #3304, #3333, #3335. Patch from David Bolter (CLA on file)

Note: See TracTickets for help on using tickets.