Opened 12 years ago

Closed 12 years ago

#3327 closed enhancement (fixed)

add Dialog and noir to themeTester, again.

Reported by: guest Owned by: bill
Priority: low Milestone: 0.9
Component: Dijit Version: 0.9
Keywords: dialog themeTester noir Cc:
Blocked By: Blocking:

Description

just a patch to themeTester with 'noir' as an added theme, and two dijit.layout.Dialogs() with anchors in the 'Tooltips' pane.

patch displays a bug in Dialog which has a tickets (?), but no test-case ...

[cla on file], pete higgins

Attachments (2)

themeTester.patch (1.9 KB) - added by guest 12 years ago.
themeTester.2.patch (18.7 KB) - added by guest 12 years ago.

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by guest

Attachment: themeTester.patch added

Changed 12 years ago by guest

Attachment: themeTester.2.patch added

comment:1 Changed 12 years ago by guest

sorry - lots of comments added to track down stray div and for cleanup, and some little tiny fixes. use themeTester.2.patch

NOW dialog properly displays error test case ... (only in FF, only shows once, click on bg to close seems true, but has been 'removed' from code? ) ...

themeTester seems to work A-OK in IE now, probably my stray div. cannot test webkit.

[cla] pete higgins

comment:2 Changed 12 years ago by bill

OK I'm going to check this in but there are a few things I had to change

  • some spelling mistakes
  • dialog should not have width/height specified
  • since this file is html you shouldn't have the <foo /> syntax (some of that syntax seems to have been there before your changes too)

comment:3 Changed 12 years ago by bill

Resolution: fixed
Status: newclosed

(In [9054]) Add some comments and Dialog to themeTester page. Patch from Pete Higgins (CLA on file). Fixes #3327

Note: See TracTickets for help on using tickets.