Opened 12 years ago

Closed 12 years ago

#3304 closed defect (fixed)

first tree item should be in the tab order - not the tree container

Reported by: Becky Gibson Owned by: davidb
Priority: high Milestone: 0.9beta
Component: Accessibility Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

Currently the tree container element is in the tab order of the page. When the tree is created, the first tree item should be in the tab order rather than the tree container element. Only one tree item should ever be in the tab order at any one time. The last tree item with focus is the one which remains in the tab order. This way if someone tabs out of the tree control and then tabs back into the tree control, focus goes to the last tree item node accessed.

Attachments (5)

3304-move-focus.diff (1.1 KB) - added by davidb 12 years ago.
fix (based on approach 1)
3304-move-focus.2.diff (1.6 KB) - added by davidb 12 years ago.
as before but removes tree root dom node from tab order.
3304-move-focus.3.diff (3.0 KB) - added by davidb 12 years ago.
added fix for 3335 but not yet 3333
3304-move-focus.4.diff (5.2 KB) - added by davidb 12 years ago.
fix for: 3304 3333 3335
3304-move-focus.5.diff (5.2 KB) - added by davidb 12 years ago.
fix for: 3304 3333 3335 (updated against a fresher trunk to resolve conflicts)

Download all attachments as: .zip

Change History (8)

comment:1 Changed 12 years ago by davidb

Status: newassigned

comment:2 Changed 12 years ago by davidb

There are two approaches I'm thinking of: 1 - when a user tabs to the tree, automatically move focus to the first child 2 - programmatically set only the first child to be in the tab order

1 - is simple to implement. 2 - requires us to keep checking to make sure the first tree item hasn't changed (on add child etc.) and might be a bit heavy.

Both approaches have a bit of an odd smell to them.

Changed 12 years ago by davidb

Attachment: 3304-move-focus.diff added

fix (based on approach 1)

Changed 12 years ago by davidb

Attachment: 3304-move-focus.2.diff added

as before but removes tree root dom node from tab order.

Changed 12 years ago by davidb

Attachment: 3304-move-focus.3.diff added

added fix for 3335 but not yet 3333

Changed 12 years ago by davidb

Attachment: 3304-move-focus.4.diff added

fix for: 3304 3333 3335

Changed 12 years ago by davidb

Attachment: 3304-move-focus.5.diff added

fix for: 3304 3333 3335 (updated against a fresher trunk to resolve conflicts)

comment:3 Changed 12 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [9105]) Fixes for focus/keyboard support for tree. Fixes #3304, #3333, #3335. Patch from David Bolter (CLA on file)

Note: See TracTickets for help on using tickets.