Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#3298 closed defect (fixed)

dojo.dnd.Mover does not work with iframes

Reported by: Douglas Hays Owned by: Eugene Lazutkin
Priority: high Milestone: 0.9beta
Component: DnD Version: 0.9
Keywords: Cc: Douglas Hays
Blocked By: Blocking:

Description

dojo.dnd.Mover and dojo._abs have dojo.doc hardcoded even though both functions have a node as a parameter. dojo._abs is called by dojo.coords from within dojo.dnd.Mover.
Instead of hardcoding dojo.doc, these functions should use:
node.ownerDocument
in order to work with nodes within iframes.
If this gets fixed soon, then the Slider widget will be able to constrain dragging motion with a transparent iframe and will reduce the widget code size. I will attach a patch file.

Attachments (1)

3298.patch (1.8 KB) - added by Douglas Hays 12 years ago.
possible fix for review and commit

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by Douglas Hays

Attachment: 3298.patch added

possible fix for review and commit

comment:1 Changed 12 years ago by Douglas Hays

Cc: Douglas Hays added
Milestone: 0.40.9beta

comment:2 Changed 12 years ago by alex

why would generating another document (an iframe) be a good way to constrain things for slider? It sounds brutally inefficient.

comment:3 Changed 12 years ago by Eugene Lazutkin

Resolution: fixed
Status: newclosed

(In [8947]) Making sure that the correct document is used for move operations. Tahnk you, doughays! Fixes #3298.

comment:4 Changed 12 years ago by Eugene Lazutkin

This bug has to be fixed in order to work with iframes correctly. But I agree with Alex --- using iframes to constrain moves is inefficient. I am implementing the constrained move today/tomorrow. Just wait for it.

Note: See TracTickets for help on using tickets.