#3298 closed defect (fixed)
dojo.dnd.Mover does not work with iframes
| Reported by: | Douglas Hays | Owned by: | Eugene Lazutkin |
|---|---|---|---|
| Priority: | high | Milestone: | 0.9beta |
| Component: | DnD | Version: | 0.9 |
| Keywords: | Cc: | Douglas Hays | |
| Blocked By: | Blocking: |
Description
dojo.dnd.Mover and dojo._abs have dojo.doc hardcoded even though both functions have a node as a parameter. dojo._abs is called by dojo.coords from within dojo.dnd.Mover.
Instead of hardcoding dojo.doc, these functions should use:
node.ownerDocument
in order to work with nodes within iframes.
If this gets fixed soon, then the Slider widget will be able to constrain dragging motion with a transparent iframe and will reduce the widget code size. I will attach a patch file.
Attachments (1)
Change History (5)
Changed 12 years ago by
| Attachment: | 3298.patch added |
|---|
comment:1 Changed 12 years ago by
| Cc: | Douglas Hays added |
|---|---|
| Milestone: | 0.4 → 0.9beta |
comment:2 Changed 12 years ago by
why would generating another document (an iframe) be a good way to constrain things for slider? It sounds brutally inefficient.
comment:3 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:4 Changed 12 years ago by
This bug has to be fixed in order to work with iframes correctly. But I agree with Alex --- using iframes to constrain moves is inefficient. I am implementing the constrained move today/tomorrow. Just wait for it.
possible fix for review and commit