Opened 12 years ago

Closed 12 years ago

Last modified 9 years ago

#3287 closed defect (fixed)

_DropDownTextbox: open method position

Reported by: bill Owned by: haysmark
Priority: high Milestone: 0.9
Component: Dijit - Form Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

(as I mentioned in email or IM, I forget which) DateTextBox? injects an open() method into the Calendar popup widget (by setting it in popupArgs),and then _DropDownTextBox calls

this._popupWidget.open(...)

It's better design to just have the open method in the widget that extends _DropDownTextBox, so that the Calendar is completely decoupled from knowing anything about popping up.

Similarly for dijit.form._ComboBoxMenu the open() method is better put on Combobox itself.

Change History (2)

comment:1 Changed 12 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [9032]) Fixes #3287. Proxy commit for haysmark. Moved open() out of the popups.

comment:2 Changed 9 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.