#3282 closed defect (fixed)
dijit.base.Container.getChildren() returns children in reverse order on IE
| Reported by: | simonjb | Owned by: | alex |
|---|---|---|---|
| Priority: | high | Milestone: | 0.9beta |
| Component: | Dijit | Version: | 0.9 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
I noticed a recent regression in PopupMenu key navigation on IE(6&7):
- when you open the menu the last item is focused instead of the first
- when you arrow to the top or bottom of the menu you get stuck -- focus does not cycle round
I traced this regression to a recent change in Container.js: on IE Container.getChildren() is returning the list of children in the reverse order to which they appear in the document.
I decided to have a go at writing up a DOH test case to show the behavior (and to test in future that we don't regress).
Attachments (2)
Change History (9)
Changed 13 years ago by
| Attachment: | ContainerGetChildrenTest.diff added |
|---|
comment:1 Changed 13 years ago by
| Cc: | alex added |
|---|
comment:2 Changed 13 years ago by
| Summary: | dijit.Container.getChildren() returns children in reverse order on IE → dijit.base.Container.getChildren() returns children in reverse order on IE |
|---|
comment:4 Changed 13 years ago by
| Cc: | alex removed |
|---|---|
| Owner: | changed from bill to alex |
I'm just calling dojo.query() in getChildren()... which I assumed would return the children in document order. Passing to Alex, at least for comment (and incorporation of unit test case). Good catch on this problem.
Changed 13 years ago by
| Attachment: | QueryTest.diff added |
|---|
comment:5 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Alex fixed this in [8959]
comment:6 Changed 13 years ago by
comment:7 Changed 13 years ago by
Note: See
TracTickets for help on using
tickets.
Alex, I'm wondering if you would be able to have a quick look at my DOH test case please? It's the first I've written and I'm not sure that I did everything correctly/the best. Thanks!